From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18302: MSYS2 build issues Date: Fri, 22 Aug 2014 09:10:55 +0300 Message-ID: <83fvgpawb4.fsf@gnu.org> References: <83zjezb00n.fsf@gnu.org> <83y4ujaxiv.fsf@gnu.org> <83tx55c3to.fsf@gnu.org> <53F63C95.6030303@cornell.edu> <83iollbqbn.fsf@gnu.org> <53F664CF.1060705@cornell.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1408687949 16322 80.91.229.3 (22 Aug 2014 06:12:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 22 Aug 2014 06:12:29 +0000 (UTC) Cc: karol.ostrovsky@gmail.com, chriszheng99@gmail.com, 18302@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 22 08:12:18 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XKi5C-0008U8-Hy for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Aug 2014 08:12:18 +0200 Original-Received: from localhost ([::1]:35248 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKi5C-0007vt-4R for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Aug 2014 02:12:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKi55-0007ur-IZ for bug-gnu-emacs@gnu.org; Fri, 22 Aug 2014 02:12:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKi4w-0002Eb-IS for bug-gnu-emacs@gnu.org; Fri, 22 Aug 2014 02:12:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKi4w-0002EX-Fz for bug-gnu-emacs@gnu.org; Fri, 22 Aug 2014 02:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XKi4v-0005hS-Vl for bug-gnu-emacs@gnu.org; Fri, 22 Aug 2014 02:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Aug 2014 06:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18302 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18302-submit@debbugs.gnu.org id=B18302.140868786521831 (code B ref 18302); Fri, 22 Aug 2014 06:12:01 +0000 Original-Received: (at 18302) by debbugs.gnu.org; 22 Aug 2014 06:11:05 +0000 Original-Received: from localhost ([127.0.0.1]:49255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XKi40-0005g3-MR for submit@debbugs.gnu.org; Fri, 22 Aug 2014 02:11:05 -0400 Original-Received: from mtaout27.012.net.il ([80.179.55.183]:46929) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XKi3w-0005fS-S7 for 18302@debbugs.gnu.org; Fri, 22 Aug 2014 02:11:02 -0400 Original-Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NAP00N001VUZA00@mtaout27.012.net.il> for 18302@debbugs.gnu.org; Fri, 22 Aug 2014 09:05:40 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NAP00J9S29GSE50@mtaout27.012.net.il>; Fri, 22 Aug 2014 09:05:40 +0300 (IDT) In-reply-to: <53F664CF.1060705@cornell.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92587 Archived-At: > Date: Thu, 21 Aug 2014 17:29:51 -0400 > From: Ken Brown > CC: karol.ostrovsky@gmail.com, chriszheng99@gmail.com, 18302@debbugs.gnu.org > > > #if defined __CYGWIN__ && !defined HAVE_X_WINDOWS > > #include > > #else > > #include > > #endif > > I neglected to say that xpm.h in /usr/include/noX is actually a symlink > to /usr/include/noX/X11/xpm.h. I don't see how this changes anything. You could use #include or you could remain with , they both will work. > The code that includes xpm.h (in > image.c) is '#include "X11/xpm.h"' on all platforms. For the native > Windows build and the Cygwin w32 build, this is done conditionally on > NTGUI, after first defining some macros. In order for "X11/xpm.h" to > produce the correct file, the include path has to be set up correctly. That just means we need to re-arrange the #ifdef's a bit differently. Clearly, not rocket science. > I really don't want to rewrite all this for no good reason. As I said, this is your call. My point is that adding system-dependent -I switches in configure is not the only way, and IMO not the best one. > > The way we work around the problem now will break if someone installs > > the standard header files in a place other than /usr/include. > > In the Cygwin case, I'm not sure what you mean by "someone". The end-user, of course. Posix platforms don't limit end-users in where they install their header files, and GCC supports that. > I'll add a comment to configure.ac on the trunk. Thanks, but why not on the release branch? A comment cannot possibly do any harm.