From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20419: 25.0.50; doc string of `recenter-last-op` Date: Sat, 25 Apr 2015 19:14:29 +0300 Message-ID: <83fv7oxk0q.fsf@gnu.org> References: <45b241f3-fe0d-4147-8726-0c06361f2199@default> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1429978531 21324 80.91.229.3 (25 Apr 2015 16:15:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 25 Apr 2015 16:15:31 +0000 (UTC) Cc: 20419@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 25 18:15:19 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ym2jY-0007rY-WA for geb-bug-gnu-emacs@m.gmane.org; Sat, 25 Apr 2015 18:15:13 +0200 Original-Received: from localhost ([::1]:48854 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ym2jY-0000wv-5g for geb-bug-gnu-emacs@m.gmane.org; Sat, 25 Apr 2015 12:15:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ym2jU-0000uw-I9 for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2015 12:15:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ym2jO-0002ci-OU for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2015 12:15:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50160) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ym2jO-0002cV-M3 for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2015 12:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Ym2jO-0005TU-8A for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2015 12:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Apr 2015 16:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20419 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20419-submit@debbugs.gnu.org id=B20419.142997849421016 (code B ref 20419); Sat, 25 Apr 2015 16:15:02 +0000 Original-Received: (at 20419) by debbugs.gnu.org; 25 Apr 2015 16:14:54 +0000 Original-Received: from localhost ([127.0.0.1]:39936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ym2jF-0005Su-UR for submit@debbugs.gnu.org; Sat, 25 Apr 2015 12:14:54 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:42404) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ym2jD-0005Sf-6G for 20419@debbugs.gnu.org; Sat, 25 Apr 2015 12:14:52 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NND00G00E2VIF00@a-mtaout22.012.net.il> for 20419@debbugs.gnu.org; Sat, 25 Apr 2015 19:14:44 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NND00GB4EGJCU40@a-mtaout22.012.net.il>; Sat, 25 Apr 2015 19:14:44 +0300 (IDT) In-reply-to: <45b241f3-fe0d-4147-8726-0c06361f2199@default> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:102032 Archived-At: > Date: Sat, 25 Apr 2015 09:12:07 -0700 (PDT) > From: Drew Adams > Cc: 20419-done@debbugs.gnu.org > > > Yuck! Why not set it to the first member of recenter-positions to > > begin with? > > > > FWIW, I consider this, including the exposure of this variable as > > some kind of knob for other Lisp packages, bad style. You should be > > demanding cleaning this up instead of documenting it. > > > > Fixed under protest. > > Point taken. A better design (for its use in `perform-replace') > might bind `recenter-last-op' to the car of `recenter-positions'. I'd rather suggest to have a simple function, recenter-reset-cycle, say, and then hide its internals inside window.el.