all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 20419@debbugs.gnu.org
Subject: bug#20419: 25.0.50; doc string of `recenter-last-op`
Date: Sat, 25 Apr 2015 19:14:29 +0300	[thread overview]
Message-ID: <83fv7oxk0q.fsf@gnu.org> (raw)
In-Reply-To: <45b241f3-fe0d-4147-8726-0c06361f2199@default>

> Date: Sat, 25 Apr 2015 09:12:07 -0700 (PDT)
> From: Drew Adams <drew.adams@oracle.com>
> Cc: 20419-done@debbugs.gnu.org
> 
> > Yuck!  Why not set it to the first member of recenter-positions to
> > begin with?
> > 
> > FWIW, I consider this, including the exposure of this variable as
> > some kind of knob for other Lisp packages, bad style.  You should be
> > demanding cleaning this up instead of documenting it.
> > 
> > Fixed under protest.
> 
> Point taken.  A better design (for its use in `perform-replace')
> might bind `recenter-last-op' to the car of `recenter-positions'.

I'd rather suggest to have a simple function, recenter-reset-cycle,
say, and then hide its internals inside window.el.





  reply	other threads:[~2015-04-25 16:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<162fcb99-b1ac-4afa-8c95-e8d171f07153@default>
     [not found] ` <<83iockxnog.fsf@gnu.org>
2015-04-25 16:12   ` bug#20419: 25.0.50; doc string of `recenter-last-op` Drew Adams
2015-04-25 16:14     ` Eli Zaretskii [this message]
     [not found] <<45b241f3-fe0d-4147-8726-0c06361f2199@default>
     [not found] ` <<83fv7oxk0q.fsf@gnu.org>
2015-04-25 16:33   ` Drew Adams
     [not found] <<3c528679-060f-45ce-994c-fdbaada6de9d@default>
     [not found] ` <<83tww4y81l.fsf@gnu.org>
2015-04-25 14:29   ` Drew Adams
2015-04-25 14:55     ` Eli Zaretskii
2015-04-24 17:16 Drew Adams
2015-04-25  7:35 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fv7oxk0q.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=20419@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.