From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Patch for warnings in 64bit Windows builds Date: Fri, 31 Jul 2015 09:55:43 +0300 Message-ID: <83fv44x1cg.fsf@gnu.org> References: <83io94xuwx.fsf@gnu.org> <86y4hxl5cw.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1438325773 1701 80.91.229.3 (31 Jul 2015 06:56:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 31 Jul 2015 06:56:13 +0000 (UTC) Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 31 08:56:01 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZL4Ea-0001oo-JV for ged-emacs-devel@m.gmane.org; Fri, 31 Jul 2015 08:56:00 +0200 Original-Received: from localhost ([::1]:43364 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZL4EZ-0002OG-U1 for ged-emacs-devel@m.gmane.org; Fri, 31 Jul 2015 02:55:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZL4EX-0002O6-0V for emacs-devel@gnu.org; Fri, 31 Jul 2015 02:55:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZL4ES-0001XP-Px for emacs-devel@gnu.org; Fri, 31 Jul 2015 02:55:56 -0400 Original-Received: from mtaout26.012.net.il ([80.179.55.182]:42486) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZL4ES-0001VZ-HT for emacs-devel@gnu.org; Fri, 31 Jul 2015 02:55:52 -0400 Original-Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0NSC00I00B3YVM00@mtaout26.012.net.il> for emacs-devel@gnu.org; Fri, 31 Jul 2015 09:59:12 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NSC00H7MBEOVT20@mtaout26.012.net.il>; Fri, 31 Jul 2015 09:59:12 +0300 (IDT) In-reply-to: <86y4hxl5cw.fsf@gmail.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188223 Archived-At: > From: Andy Moreton > Date: Thu, 30 Jul 2015 22:09:51 +0100 > > I've noticed some other warnings in the 64bit mingw64 builds requiring > a similar fix: > > ../../src/w32.c: In function 'maybe_load_unicows_dll': > ../../src/w32.c:9174:25: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types] > pMultiByteToWideChar = GetProcAddress (ret, "MultiByteToWideChar"); > ^ > ../../src/w32.c:9175:25: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types] > pWideCharToMultiByte = GetProcAddress (ret, "WideCharToMultiByte"); > ^ > > There is also a warning about socket handling: > > ../../src/w32.c: In function 'sys_socket': > ../../src/w32.c:7336:14: warning: overflow in implicit constant conversion [-Woverflow] > return INVALID_SOCKET; > ^ > c:/msys64/mingw64/x86_64-w64-mingw32/include/psdk_inc/_socket_types.h > contains: > > #if 1 > typedef UINT_PTR SOCKET; > #else > typedef INT_PTR SOCKET; > #endif > > #define INVALID_SOCKET (SOCKET)(~0) > > Thus it is corect to warn about a conversion from unsigned 64bit to a > signed 32bit value. Please propose changes to eliminate those. (I can propose them myself, but I cannot test them.) > >> I don't have copyright paperwork on file, so please let me know if that > >> is required. > > > > Not needed, but you are encouraged to start the paperwork rolling, so > > it will be ready for your next contribution. > > Where do I find the appropriate forms ? One place is in Gnulib's Git repository, in the doc/Copyright/ directory. You want the file request-assign.future. There are some explanations in https://www.gnu.org/prep/maintain/html_node/Copyright-Papers.html, but the form is pretty much self-explanatory. Thanks.