From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add shell-quasiquote. Date: Tue, 20 Oct 2015 18:40:24 +0300 Message-ID: <83fv15ft07.fsf@gnu.org> References: <87si59wj42.fsf@T420.taylan> <878u6znii9.fsf@T420.taylan> <836123gfh2.fsf@gnu.org> <87r3krm0t3.fsf@T420.taylan> <5624F66F.1030600@yandex.ru> <87io63lzkg.fsf@T420.taylan> <562508B7.3020202@yandex.ru> <876122n5v3.fsf@T420.taylan> <22053.50324.60123.654292@turnbull.sk.tsukuba.ac.jp> <87d1waknl1.fsf@T420.taylan> <87oafugeia.fsf@fencepost.gnu.org> <87wpuij5vm.fsf@T420.taylan> <87d1w9hql5.fsf@fencepost.gnu.org> <87oaftkjhg.fsf@T420.taylan> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: ger.gmane.org 1445355728 21186 80.91.229.3 (20 Oct 2015 15:42:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 20 Oct 2015 15:42:08 +0000 (UTC) Cc: emacs-devel@gnu.org To: taylanbayirli@gmail.com (Taylan Ulrich =?utf-8?Q?Bay=C4=B1rl=C4=B1=2FK?= =?utf-8?Q?ammer?=) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 20 17:42:00 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZoZ2j-0005vR-4R for ged-emacs-devel@m.gmane.org; Tue, 20 Oct 2015 17:41:41 +0200 Original-Received: from localhost ([::1]:46632 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoZ2i-00041A-2s for ged-emacs-devel@m.gmane.org; Tue, 20 Oct 2015 11:41:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoZ1W-0003Et-Q2 for emacs-devel@gnu.org; Tue, 20 Oct 2015 11:40:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoZ1R-0003me-PQ for emacs-devel@gnu.org; Tue, 20 Oct 2015 11:40:26 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:33427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoZ1R-0003lP-Ex for emacs-devel@gnu.org; Tue, 20 Oct 2015 11:40:21 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NWI00800ZENGC00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Tue, 20 Oct 2015 18:40:19 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NWI008YRZJ7DD30@a-mtaout21.012.net.il>; Tue, 20 Oct 2015 18:40:19 +0300 (IDT) In-reply-to: <87oaftkjhg.fsf@T420.taylan> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192190 Archived-At: > From: taylanbayirli@gmail.com (Taylan Ulrich Bay=C4=B1rl=C4=B1/Kamm= er) > Date: Tue, 20 Oct 2015 10:54:51 +0200 > Cc: "Stephen J. Turnbull" , > =09emacs-devel >=20 > I didn't break anything, explained why I could not support non-POSI= X > without Eli's help, asked for proper help, drafted a patch where he > could have just filled the blanks in documentation to declare the > required safety guarantees for non-POSIX systems, but nope... This is not about non-Posix shells (although that aspect did start this thread). This is about using project-wide APIs for certain standard jobs. That should have been a no-brainer, because it makes no sense to have several functions doing the same job in subtly different ways. So you were politely requested to call that function for quoting shel= l arguments in your package. Doing that is the only thing that stands in the way of accepting your package on ELPA. AFAIK, there were no other comments. If you think shell-quote-argument should be changed, feel free to submit a patch proposal to that effect, and state there your reasons for the changes. If they are accepted, all Lisp programs in Emacs that need to quote command arguments will work that way, and everybod= y will win by having a better Emacs. I cannot understand why you insist on tying your contribution with tw= o orthogonal issues: what and how should be quoted, and what should be in the doc string. By doing this, you prevent acceptance of your package, which IMO is a pity.