From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22101: Emacs-25: inaccuracy in documentation of `mapconcat' in .../lispref/functions.texi Date: Mon, 07 Dec 2015 17:51:24 +0200 Message-ID: <83fuzedzpf.fsf@gnu.org> References: <20151206102622.GA2113@acm.fritz.box> <83vb8bef6p.fsf@gnu.org> <20151207105457.GA1904@acm.fritz.box> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1449503552 4942 80.91.229.3 (7 Dec 2015 15:52:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 7 Dec 2015 15:52:32 +0000 (UTC) Cc: 22101@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 07 16:52:21 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a5y5I-0000VR-F0 for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Dec 2015 16:52:16 +0100 Original-Received: from localhost ([::1]:55209 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5y5H-0000LD-Rp for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Dec 2015 10:52:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5y59-0000BW-Gc for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2015 10:52:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a5y54-0005Nl-4R for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2015 10:52:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52154) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5y54-0005NH-0D for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2015 10:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a5y53-0005uS-Ml for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2015 10:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Dec 2015 15:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22101-submit@debbugs.gnu.org id=B22101.144950351222702 (code B ref 22101); Mon, 07 Dec 2015 15:52:01 +0000 Original-Received: (at 22101) by debbugs.gnu.org; 7 Dec 2015 15:51:52 +0000 Original-Received: from localhost ([127.0.0.1]:41862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a5y4u-0005u5-DI for submit@debbugs.gnu.org; Mon, 07 Dec 2015 10:51:52 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:35483) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a5y4Z-0005te-51 for 22101@debbugs.gnu.org; Mon, 07 Dec 2015 10:51:51 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NYZ00A00VQSFJ00@a-mtaout23.012.net.il> for 22101@debbugs.gnu.org; Mon, 07 Dec 2015 17:51:29 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NYZ00AC6W1SAD90@a-mtaout23.012.net.il>; Mon, 07 Dec 2015 17:51:28 +0200 (IST) In-reply-to: <20151207105457.GA1904@acm.fritz.box> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109709 Archived-At: > Date: Mon, 7 Dec 2015 10:54:58 +0000 > Cc: 22101-done@debbugs.gnu.org > From: Alan Mackenzie > > > IMO, this errs on the other side: it seems to allow sequences that > > will be rejected by mapconcat or by concat that it calls. I suggest > > the following alternative wording: > > > @code{mapconcat} applies @var{function} to each element of > > @var{sequence}; the results, which must be sequences of characters > > (strings, vectors, or lists), are concatenated into a single string > > return value. Between each pair of result sequences, > > @code{mapconcat} inserts the characters from @var{separator}, which > > also must be a string, or a vector or list of characters. > > > The argument @var{function} must be a function that can take one > > argument and return a sequence of characters: a string, a vector, or > > a list. The argument @var{sequence} can be any kind of sequence > > except a char-table; that is, a list, a vector, a bool-vector, or a > > string. > > > WDYT? > > I think it's good. I have just taken the liberty of committing your > version Such an impatience... Did you forget to push? > with two changes: I have added @xref{Sequences Arrays Vectors} > at the end of the first paragraph. It should be way up in the text preceding this @defun, because the section talks about sequences much earlier, and it makes no sense to have the cross-reference so late in the text. Thanks.