From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: About x_draw_xwidget_glyph_string Date: Sat, 09 Apr 2016 15:06:08 +0300 Message-ID: <83fuuvhtqn.fsf@gnu.org> References: <83oac93bnr.fsf@gnu.org> <83shyvi64r.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1460203650 6035 80.91.229.3 (9 Apr 2016 12:07:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 9 Apr 2016 12:07:30 +0000 (UTC) Cc: mituharu@math.s.chiba-u.ac.jp, emacs-devel@gnu.org To: joakim@verona.se Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 09 14:07:28 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aorfj-0000zV-NY for ged-emacs-devel@m.gmane.org; Sat, 09 Apr 2016 14:07:27 +0200 Original-Received: from localhost ([::1]:60178 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aorfj-00031L-1W for ged-emacs-devel@m.gmane.org; Sat, 09 Apr 2016 08:07:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aorf7-0002OA-Lp for emacs-devel@gnu.org; Sat, 09 Apr 2016 08:06:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aorf4-0005sO-DN for emacs-devel@gnu.org; Sat, 09 Apr 2016 08:06:49 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39700) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aorf4-0005sJ-9e; Sat, 09 Apr 2016 08:06:46 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1516 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aorf3-00046l-I3; Sat, 09 Apr 2016 08:06:45 -0400 In-reply-to: (joakim@verona.se) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:202826 Archived-At: > From: joakim@verona.se > Cc: mituharu@math.s.chiba-u.ac.jp, emacs-devel@gnu.org > Date: Sat, 09 Apr 2016 13:22:52 +0200 > > >> This is my attempt to replace the code above: > >> > >> //JAVE work in progressing, suggested by YAMAMOTO Mitsuharu > >> int text_area_x, text_area_y, text_area_width, text_area_height; > >> > >> window_box (s->w, > >> ANY_AREA, //also tried TEXT_AREA > > > > You should use TEXT_AREA here. > > > >> &text_area_x, > >> &text_area_y, > >> &text_area_width, > >> &text_area_height); > >> clip_right = > >> min (xww->width, > >> text_area_width); > >> clip_left = > >> max (0, > >> text_area_x); > >> > >> clip_bottom = > >> min (xww->height, > >> text_area_y); > >> clip_top = max (0, text_area_height); > > > > I think clip_top should use text_area_y and clip_bottom should use > > text_area_height. > > > > Other than those two issues, what other problems do you see? > > Well, I saw nothing at all :) Thanks, pushed to the emacs-25 branch.