Re: About x_draw_xwidget_glyph_string

[Eli Zaretskii <eliz@gnu.org>]

> From: joakim@verona.se
> Cc: mituharu@math.s.chiba-u.ac.jp,  emacs-devel@gnu.org
> Date: Sat, 09 Apr 2016 13:22:52 +0200
> 
> >> This is my attempt to replace the code above:
> >> 
> >>   //JAVE work in progressing, suggested by YAMAMOTO Mitsuharu
> >>   int text_area_x, text_area_y, text_area_width, text_area_height;
> >>   
> >>   window_box (s->w,
> >>               ANY_AREA, //also tried TEXT_AREA
> >
> > You should use TEXT_AREA here.
> >
> >>               &text_area_x,
> >>               &text_area_y,
> >>               &text_area_width,
> >>               &text_area_height);
> >>   clip_right =
> >>     min (xww->width,
> >>          text_area_width);
> >>   clip_left =
> >>     max (0,
> >>          text_area_x);
> >> 
> >>   clip_bottom =
> >>     min (xww->height,
> >>          text_area_y);
> >>   clip_top = max (0, text_area_height);
> >
> > I think clip_top should use text_area_y and clip_bottom should use
> > text_area_height.
> >
> > Other than those two issues, what other problems do you see?
> 
> Well, I saw nothing at all :)

Thanks, pushed to the emacs-25 branch.