From: Eli Zaretskii <eliz@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 23276@debbugs.gnu.org, andlind@gmail.com
Subject: bug#23276: 25.0.92; Crash in auto-revert when file no longer present
Date: Sat, 16 Apr 2016 22:00:32 +0300 [thread overview]
Message-ID: <83fuulbcq7.fsf@gnu.org> (raw)
In-Reply-To: <87vb3hgzr1.fsf@gmx.de> (message from Michael Albinus on Sat, 16 Apr 2016 20:44:18 +0200)
> From: Michael Albinus <michael.albinus@gmx.de>
> Date: Sat, 16 Apr 2016 20:44:18 +0200
> Cc: 23276@debbugs.gnu.org
>
> Does anybody object to install the following patch in the emacs-25 branch?
>
> --8<---------------cut here---------------start------------->8---
> *** /home/albinus/src/emacs-25/lisp/autorevert.el.~f3653ec446ed95404889cf16c67b2d96b3955f52~ 2016-04-16 20:38:55.247491182 +0200
> --- /home/albinus/src/emacs-25/lisp/autorevert.el 2016-04-16 20:36:29.485457375 +0200
> ***************
> *** 684,690 ****
> ;; not to forget that. This gives undesirable results when
> ;; the file's mode changes, but that is less common.
> (let ((buffer-read-only buffer-read-only))
> ! (revert-buffer 'ignore-auto 'dont-ask 'preserve-modes)))
> (when buffer-file-name
> (when eob (goto-char (point-max)))
> (dolist (window eoblist)
> --- 684,691 ----
> ;; not to forget that. This gives undesirable results when
> ;; the file's mode changes, but that is less common.
> (let ((buffer-read-only buffer-read-only))
> ! (ignore-errors
> ! (revert-buffer 'ignore-auto 'dont-ask 'preserve-modes))))
> (when buffer-file-name
> (when eob (goto-char (point-max)))
> (dolist (window eoblist)
> --8<---------------cut here---------------end--------------->8---
It should have a comment explaining why errors are being ignored.
And I still am not convinced that deleting a file under auto-revert
shouldn't erase its buffer. Otherwise, it sounds like just
half-auto-revert to me. Would we keep the buffer non-empty if the
file existed but was empty?
Thanks.
next prev parent reply other threads:[~2016-04-16 19:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 11:07 bug#23276: 25.0.92; Crash in auto-revert when file no longer present Anders Lindgren
2016-04-12 15:16 ` Eli Zaretskii
2016-04-12 16:14 ` Michael Albinus
2016-04-16 18:44 ` Michael Albinus
2016-04-16 18:55 ` Anders Lindgren
2016-04-16 20:56 ` Michael Albinus
2016-04-16 19:00 ` Eli Zaretskii [this message]
2016-04-16 20:35 ` Michael Albinus
2016-04-16 20:56 ` Anders Lindgren
2016-04-16 21:30 ` Michael Albinus
2016-04-17 1:54 ` John Wiegley
2016-04-17 2:39 ` Eli Zaretskii
2016-04-17 2:53 ` John Wiegley
2016-04-17 2:57 ` John Mastro
2016-04-17 8:52 ` Michael Albinus
2016-04-18 8:26 ` Michael Albinus
2016-04-17 13:20 ` Óscar Fuentes
2016-04-17 15:16 ` Eli Zaretskii
2016-04-17 16:01 ` Óscar Fuentes
2016-04-17 16:10 ` Eli Zaretskii
2016-04-18 8:24 ` Michael Albinus
2020-12-29 20:02 ` bug#23276: autorevert for a deleted dired directory (ref: 23276) Boruch Baum
2020-12-29 20:13 ` Eli Zaretskii
2020-12-29 20:45 ` Boruch Baum
2020-12-29 20:24 ` Drew Adams
2020-12-29 21:18 ` Boruch Baum
2020-12-29 22:07 ` Drew Adams
2022-04-27 14:09 ` bug#23276: 25.0.92; Crash in auto-revert when file no longer present Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fuulbcq7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23276@debbugs.gnu.org \
--cc=andlind@gmail.com \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.