From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22295: viper-mode undo bug introduced between Nov 10 and Nov 14 Date: Fri, 20 May 2016 16:32:07 +0300 Message-ID: <83futc97oo.fsf@gnu.org> References: <83vb2h6lfq.fsf@gnu.org> <83r3d56jrg.fsf@gnu.org> <87poso7nf5.fsf@russet.org.uk> <878tzatbte.fsf@russet.org.uk> <87k2it5bgh.fsf@russet.org.uk> <87wpmrvia7.fsf@russet.org.uk> <8737pfavrn.fsf@russet.org.uk> <83iny982x7.fsf@gnu.org> <87r3cx6jg9.fsf@russet.org.uk> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1463751216 16851 80.91.229.3 (20 May 2016 13:33:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 May 2016 13:33:36 +0000 (UTC) Cc: 22295@debbugs.gnu.org, jim@meyering.net To: phillip.lord@russet.org.uk (Phillip Lord), John Wiegley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 20 15:33:21 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b3kYB-0003Ep-Vv for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 May 2016 15:33:12 +0200 Original-Received: from localhost ([::1]:54862 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3kYB-0000C4-0z for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 May 2016 09:33:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3kY5-0000By-EB for bug-gnu-emacs@gnu.org; Fri, 20 May 2016 09:33:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3kY2-0002aJ-8O for bug-gnu-emacs@gnu.org; Fri, 20 May 2016 09:33:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46360) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3kY2-0002aB-5O for bug-gnu-emacs@gnu.org; Fri, 20 May 2016 09:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b3kY2-0005Wv-1h for bug-gnu-emacs@gnu.org; Fri, 20 May 2016 09:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 May 2016 13:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22295 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22295-submit@debbugs.gnu.org id=B22295.146375113921208 (code B ref 22295); Fri, 20 May 2016 13:33:02 +0000 Original-Received: (at 22295) by debbugs.gnu.org; 20 May 2016 13:32:19 +0000 Original-Received: from localhost ([127.0.0.1]:58697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b3kXL-0005Vz-IJ for submit@debbugs.gnu.org; Fri, 20 May 2016 09:32:19 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38943) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b3kXJ-0005Vm-GS for 22295@debbugs.gnu.org; Fri, 20 May 2016 09:32:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3kXD-0002Sk-Hv for 22295@debbugs.gnu.org; Fri, 20 May 2016 09:32:12 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49368) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3kX9-0002SD-P3; Fri, 20 May 2016 09:32:07 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3195 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b3kX6-0003H9-QR; Fri, 20 May 2016 09:32:06 -0400 In-reply-to: <87r3cx6jg9.fsf@russet.org.uk> (phillip.lord@russet.org.uk) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118477 Archived-At: > From: phillip.lord@russet.org.uk (Phillip Lord) > Cc: Jim Meyering , 22295@debbugs.gnu.org, jwiegley@gmail.com > Date: Fri, 20 May 2016 12:46:14 +0100 > > Eli Zaretskii writes: > > > FWIW, I think this should go to emacs-25, since (a) the changes affect > > only viper-mode, and (b) users of that mode will be most unhappy > > without these changes. > > Not quite true. I've changed simple.el. I've seen the change, of course. As long as only viper-mode uses that variable, I see no danger. > > However, we should add comments to viper-cmd.el that document the > > special handling of 'undo' by viper-mode, and how that interacts with > > the core 'undo' functionalities. We should also comment in simple.el > > that undo-auto-disable-boundaries is used by viper-mode, and document > > that variable in the ELisp manual. Phillip, can you add these bits to > > the branch, please? > > Oh, yeah, sorry forgot the manual. I updated most of the rest last > night. I think that the branch is ready, bar squashing. Thanks. John, we are waiting for your verdict.