From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master ff9ddda: Simplify pre-write-conversion for utf-8-hfs coding system Date: Mon, 13 Jun 2016 17:01:12 +0300 Message-ID: <83fushfas7.fsf@gnu.org> References: <20160610080445.616.81209@vcs.savannah.gnu.org> <20160610080445.5113D220143@vcs.savannah.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1465827196 19695 80.91.229.3 (13 Jun 2016 14:13:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 13 Jun 2016 14:13:16 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: David Reitter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 13 16:13:14 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bCSc6-0005Lt-Js for ged-emacs-devel@m.gmane.org; Mon, 13 Jun 2016 16:13:14 +0200 Original-Received: from localhost ([::1]:56776 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCSc5-0006fJ-NI for ged-emacs-devel@m.gmane.org; Mon, 13 Jun 2016 10:13:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36662) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCSPh-0003UE-R7 for emacs-devel@gnu.org; Mon, 13 Jun 2016 10:00:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCSPd-0004My-NF for emacs-devel@gnu.org; Mon, 13 Jun 2016 10:00:24 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCSPd-0004Mu-Je; Mon, 13 Jun 2016 10:00:21 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3649 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bCSPc-0002RW-NN; Mon, 13 Jun 2016 10:00:21 -0400 In-reply-to: (message from David Reitter on Mon, 13 Jun 2016 17:12:21 +0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204338 Archived-At: > From: David Reitter > Date: Mon, 13 Jun 2016 17:12:21 +0800 > Cc: emacs-devel@gnu.org > > On Jun 10, 2016, at 11:54 PM, Stefan Monnier wrote: > > > Could you add a comment explaining why it's OK to ignore `from` and `to` > > here (as well as rename those args to `_from` and `_to` to make it > > clear to the byte-compiler that we purposefully ignore them)? > > I could, and I have. Thanks. > Is it okay to commit this bug fix in emacs-25? I thought we ended up realizing that there was some other factor at work, which caused a simple 'insert' in a temporary buffer trigger tool-bar update, and you were trying to find a simple recipe for reproducing that? I'd like to get to the bottom of that strange phenomenon, because it could just be that the ucs-normalize change is fixing the symptom, not the malady. Did I miss something?