From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: =?utf-8?Q?What=E2=80=99s?= the deal with #if _LIBC and other non-Emacs code? Date: Tue, 26 Jul 2016 05:34:42 +0300 Message-ID: <83fuqxt9dp.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1469500542 25805 80.91.229.3 (26 Jul 2016 02:35:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Jul 2016 02:35:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michal Nazarewicz Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 26 04:35:37 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bRsDZ-0007Yx-0c for ged-emacs-devel@m.gmane.org; Tue, 26 Jul 2016 04:35:37 +0200 Original-Received: from localhost ([::1]:37025 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRsDY-00067S-4d for ged-emacs-devel@m.gmane.org; Mon, 25 Jul 2016 22:35:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRsD0-00067L-Tq for emacs-devel@gnu.org; Mon, 25 Jul 2016 22:35:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bRsCv-0003fS-Ua for emacs-devel@gnu.org; Mon, 25 Jul 2016 22:35:01 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRsCv-0003f1-Rc; Mon, 25 Jul 2016 22:34:57 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1380 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bRsCt-0000md-FS; Mon, 25 Jul 2016 22:34:56 -0400 In-reply-to: (message from Michal Nazarewicz on Tue, 26 Jul 2016 00:58:06 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206135 Archived-At: > From: Michal Nazarewicz > Date: Tue, 26 Jul 2016 00:58:06 +0200 > > I’ve noticed quite some code in regex.c and regex.h which isn’t used by > Emacs or any executable distributed with Emacs. Most notably, there are > blocks of code guarded with ‘#ifdef _LIBC’ macro and support for > alternative syntax which is never actually used. > > To me this all looks like it could be safely removed simplifying and > shortening the code. > > I would be happy to prepare patches doing just that, but first I’d like > to make sure that there’s nothing I’m missing. This code is maintained by glibc, where those parts are used. Although our version diverged quite a lot from the one in glibc, we still have plans to merge them at some point. So I think we shouldn't remove those parts. Thanks.