From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24071: [PATCH] Refactor regex character class parsing in [:name:] Date: Wed, 27 Jul 2016 19:28:25 +0300 Message-ID: <83fuqvrqom.fsf@gnu.org> References: <1469487245-11126-1-git-send-email-mina86@mina86.com> <83d1m0tq25.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1469636970 19280 80.91.229.3 (27 Jul 2016 16:29:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Jul 2016 16:29:30 +0000 (UTC) Cc: lists@dima.secretsauce.net, 24071@debbugs.gnu.org To: Michal Nazarewicz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 27 18:29:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bSRhs-0003m2-US for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Jul 2016 18:29:17 +0200 Original-Received: from localhost ([::1]:47555 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSRhp-00012f-1j for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Jul 2016 12:29:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSRhf-0000w6-WC for bug-gnu-emacs@gnu.org; Wed, 27 Jul 2016 12:29:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSRhe-0005RQ-1v for bug-gnu-emacs@gnu.org; Wed, 27 Jul 2016 12:29:02 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55260) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSRhd-0005RL-UC for bug-gnu-emacs@gnu.org; Wed, 27 Jul 2016 12:29:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bSRhd-0007Jx-NI for bug-gnu-emacs@gnu.org; Wed, 27 Jul 2016 12:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Jul 2016 16:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24071-submit@debbugs.gnu.org id=B24071.146963692828120 (code B ref 24071); Wed, 27 Jul 2016 16:29:01 +0000 Original-Received: (at 24071) by debbugs.gnu.org; 27 Jul 2016 16:28:48 +0000 Original-Received: from localhost ([127.0.0.1]:39364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bSRhP-0007JU-VT for submit@debbugs.gnu.org; Wed, 27 Jul 2016 12:28:48 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bSRhO-0007JH-7d for 24071@debbugs.gnu.org; Wed, 27 Jul 2016 12:28:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSRhE-0005KR-Q5 for 24071@debbugs.gnu.org; Wed, 27 Jul 2016 12:28:41 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59067) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSRhE-0005KC-Ma; Wed, 27 Jul 2016 12:28:36 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3074 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bSRhC-00019O-PU; Wed, 27 Jul 2016 12:28:35 -0400 In-reply-to: (message from Michal Nazarewicz on Wed, 27 Jul 2016 17:29:04 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121586 Archived-At: > From: Michal Nazarewicz > Cc: 24071@debbugs.gnu.org > Date: Wed, 27 Jul 2016 17:29:04 +0200 > > > If we are going to make some serious refactoring in regex.c, I think > > we should start with having a test suite for it. > > I agree. Which is why I started test/src/regex-tests.el¹. Since this > patch touches only character classes I limited the tests to character > classes. I know. What I wrote was not a complaint about the past, it was a suggestion for the future. A single localized change doesn't yet justify importing a large test suite. But this later patch looks like a beginning of a series of refactoring (is it?), hopefully followed by more features, so I thought we should have a firm ground first. > > The dima_regex_embedded_modifiers branch, created by Dima Kogan > > (CC'ed) in the Emacs repository includes a suite taken from glibc. > > Dima, could you perhaps merge the parts of the test suite that can > > already be used to the master branch, so that we could use them to > > verify changes in regex.c? > > This looks relatively straightforward; I can take care of it. I’ll > send a link to the result soon. Thanks.