From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24378: [PATCH 6/6] Factor out character category lookup to separate function Date: Tue, 06 Sep 2016 18:21:46 +0300 Message-ID: <83fupdawad.fsf@gnu.org> References: <1473168498-13194-1-git-send-email-mina86@mina86.com> <1473168694-13605-1-git-send-email-mina86@mina86.com> <1473168694-13605-6-git-send-email-mina86@mina86.com> <83oa41axjb.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1473175678 19402 195.159.176.226 (6 Sep 2016 15:27:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 6 Sep 2016 15:27:58 +0000 (UTC) Cc: 24378@debbugs.gnu.org To: Michal Nazarewicz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 06 17:27:50 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhIHp-0003iY-A1 for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Sep 2016 17:27:45 +0200 Original-Received: from localhost ([::1]:34373 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhIHm-00086k-P2 for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Sep 2016 11:27:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhIDI-0003uy-Md for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 11:23:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhIDG-0002mE-NU for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 11:23:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53767) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhIDG-0002m9-K7 for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 11:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bhIDG-0000NE-GS for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 11:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2016 15:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24378-submit@debbugs.gnu.org id=B24378.14731753341346 (code B ref 24378); Tue, 06 Sep 2016 15:23:02 +0000 Original-Received: (at 24378) by debbugs.gnu.org; 6 Sep 2016 15:22:14 +0000 Original-Received: from localhost ([127.0.0.1]:51476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhICQ-0000LZ-67 for submit@debbugs.gnu.org; Tue, 06 Sep 2016 11:22:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhICL-0000L2-Bm for 24378@debbugs.gnu.org; Tue, 06 Sep 2016 11:22:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhICC-0002Ua-3s for 24378@debbugs.gnu.org; Tue, 06 Sep 2016 11:22:00 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhICC-0002UL-0O; Tue, 06 Sep 2016 11:21:56 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4132 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bhICA-0005Nn-8Y; Tue, 06 Sep 2016 11:21:54 -0400 In-reply-to: (message from Michal Nazarewicz on Tue, 06 Sep 2016 17:11:14 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123006 Archived-At: > From: Michal Nazarewicz > Cc: 24378@debbugs.gnu.org > Date: Tue, 06 Sep 2016 17:11:14 +0200 > > >> * src/character.c (char_unicode_category): New function returning Unicode > >> general category of specified character. > >> (alphabeticp, alphanumericp, graphicp, printablep): Use the above. > > > > Is there any future change that needs this refactoring? Or is there > > any other reason for this? > > I have dozen or so patches in pipeline which will build on top of this > change. I can wait with this patch and resubmit it with the rest of the > changes so it’s clearer how it all fits together. Yes, please commit this together with the changes that build on it. Thanks.