all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: noah.v.peart@gmail.com, 24899@debbugs.gnu.org
Subject: bug#24899: 25.1; x-hide-tip always returns nil with USE_GTK
Date: Tue, 08 Nov 2016 17:18:35 +0200	[thread overview]
Message-ID: <83fun2gfuc.fsf@gnu.org> (raw)
In-Reply-To: <58217D5C.1000302@gmx.at> (message from martin rudalics on Tue, 08 Nov 2016 08:23:08 +0100)

> Date: Tue, 08 Nov 2016 08:23:08 +0100
> From: martin rudalics <rudalics@gmx.at>
> 
> Thanks for the report.  I think that before investigating this further
> we need another recipe.  Yours is based on ‘pos-tip-show’ which is not
> part of Emacs.  Does ‘pos-tip-show’ use GTK+ tooltips or the native
> Emacs ones - what is your value of ‘x-gtk-use-system-tooltips’?
> 
> Then we would have to decide how to retrieve a non-nil return value for
> ‘x-hide-tip’ in the first place.  Here the tooltip disappears
> immediately when I type anything, so the return value is always nil by
> force, presumably.  We'd probably need a timer to test your function.
> 
> Finally, we would have to check the results for the function you get
> this way for both ‘x-gtk-use-system-tooltips’ nil/t settings and for at
> least one other toolkit.
> 
> Can you please try doing all that?

Martin, did you try this on master or on the emacs-25 branch?  I think
there's an omission in the Emacs 25.1 code, which the OP is running,
that is already fixed on master.  For emacs-25, the following patch
should at least bring you closer to the solution, if not be the
solution:

diff --git a/src/xfns.c b/src/xfns.c
index 7c1bb1c..a6d8980 100644
--- a/src/xfns.c
+++ b/src/xfns.c
@@ -6120,7 +6120,10 @@ Value is t if tooltip was open, nil otherwise.  */)
        the tip is shown.  */
     struct frame *f = XFRAME (frame);
     if (FRAME_LIVE_P (f) && xg_hide_tooltip (f))
-      frame = Qnil;
+      {
+	frame = Qnil;
+	deleted = Qt;
+      }
   }
 #endif
 





  reply	other threads:[~2016-11-08 15:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-08  4:18 bug#24899: 25.1; x-hide-tip always returns nil with USE_GTK nverno
2016-11-08  7:23 ` martin rudalics
2016-11-08 15:18   ` Eli Zaretskii [this message]
2016-11-08 16:41     ` martin rudalics
2016-11-08 16:47       ` Eli Zaretskii
2016-11-08 18:33         ` Noah Peart
2016-11-08 19:13           ` Noah Peart
2016-11-08 22:11             ` Noah Peart
2016-11-09  7:00               ` martin rudalics
2016-11-09 22:44                 ` Noah Peart
2017-10-10  9:15 ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fun2gfuc.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=24899@debbugs.gnu.org \
    --cc=noah.v.peart@gmail.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.