From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Bugs related to buffer-local tags-file-name Date: Thu, 01 Dec 2016 18:53:48 +0200 Message-ID: <83fum7pp43.fsf@gnu.org> References: <87zikr4a8y.fsf@gmail.com> <3f470a39-6bd4-bbb4-c693-ef889118fdf2@yandex.ru> <87wpfv3qrm.fsf@gmail.com> <838ts86atl.fsf@gnu.org> <83r3603t7o.fsf@gnu.org> <83twau1n0u.fsf@gnu.org> <87poli3ztj.fsf@gmail.com> <83polexkop.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1480611294 455 195.159.176.226 (1 Dec 2016 16:54:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 1 Dec 2016 16:54:54 +0000 (UTC) Cc: jschwab@gmail.com, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 01 17:54:45 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCUdA-0007Cp-Ud for ged-emacs-devel@m.gmane.org; Thu, 01 Dec 2016 17:54:45 +0100 Original-Received: from localhost ([::1]:57373 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCUdE-0002lX-So for ged-emacs-devel@m.gmane.org; Thu, 01 Dec 2016 11:54:48 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCUcd-0002lG-Sx for emacs-devel@gnu.org; Thu, 01 Dec 2016 11:54:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCUcZ-0001Fe-OL for emacs-devel@gnu.org; Thu, 01 Dec 2016 11:54:11 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51879) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCUcQ-0001DA-0v; Thu, 01 Dec 2016 11:53:58 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3783 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cCUcN-0005ub-4r; Thu, 01 Dec 2016 11:53:57 -0500 In-reply-to: (message from Dmitry Gutov on Wed, 30 Nov 2016 03:12:20 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209881 Archived-At: close 158 close 17326 close 23164 close 19741 thanks > Cc: emacs-devel@gnu.org > From: Dmitry Gutov > Date: Wed, 30 Nov 2016 03:12:20 +0200 > > On 29.11.2016 19:25, Eli Zaretskii wrote: > > > Dmitry, should I wait for your testing as well, or should I just push > > the changes? > > Yes, sorry. I think you should go ahead with them, maybe with some minor > tweaks. Done. > - In visit-tags-table-buffer's docstring, "optional arg CONT" should > probably be just "CONT", all three times. Fixed. > - More importantly, this patch contains a backward-incompatible change > to the tags-completion-table function. Maybe we should consider how to > make BUF an optional argument. It is optional now. > - It would be great if let-binding tags-table-list around > tags-lazy-completion-table didn't leak it to the global value either > (which happens with company-etags). Alas, this seems to be a harder task. Right, patches welcome.