From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Warning compiling obarray.el on master Date: Sat, 18 Mar 2017 15:30:29 +0200 Message-ID: <83fuiayaoa.fsf@gnu.org> References: <83inn8z3ax.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1489843867 2957 195.159.176.226 (18 Mar 2017 13:31:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 18 Mar 2017 13:31:07 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 18 14:31:03 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpERb-00082J-UQ for ged-emacs-devel@m.gmane.org; Sat, 18 Mar 2017 14:30:56 +0100 Original-Received: from localhost ([::1]:53370 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpERh-0007Da-Ro for ged-emacs-devel@m.gmane.org; Sat, 18 Mar 2017 09:31:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpERZ-0007DH-V1 for emacs-devel@gnu.org; Sat, 18 Mar 2017 09:30:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cpERW-0001w7-SG for emacs-devel@gnu.org; Sat, 18 Mar 2017 09:30:53 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:32817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpERW-0001w3-Oq; Sat, 18 Mar 2017 09:30:50 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1899 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cpERW-0002tu-1C; Sat, 18 Mar 2017 09:30:50 -0400 In-reply-to: (message from Stefan Monnier on Sat, 18 Mar 2017 08:49:05 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213114 Archived-At: > From: Stefan Monnier > Date: Sat, 18 Mar 2017 08:49:05 -0400 > > I see the rest of obarray.el uses the name `ob` for local variables > instead, so I guess using that in `obarray-copy` is the best fix in the > short term. Please do. > In the longer term, maybe we should rename `obarray` to something more > descriptive and less likely to collide with a local var. > Maybe `default-obarray` or `global-obarray` or > `global-identifier-obarray`? Perhaps, but the danger of clashing names doesn't go away with these measures, it just gets lower.