From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: emacs-devel@gnu.org
Subject: Re: moving some indentation tests
Date: Thu, 06 Apr 2017 17:11:02 +0300 [thread overview]
Message-ID: <83fuhloccp.fsf@gnu.org> (raw)
In-Reply-To: <8737dm1agq.fsf@tromey.com> (message from Tom Tromey on Wed, 05 Apr 2017 21:28:05 -0600)
> From: Tom Tromey <tom@tromey.com>
> Date: Wed, 05 Apr 2017 21:28:05 -0600
> Cc: Emacs discussions <emacs-devel@gnu.org>
>
> >>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>
> Tom> I'm thinking I would move the files to test/data and then write a new
> Tom> test that simply iterates over these files and checking that
> Tom> re-indentation works.
>
> This turns out to be kind of a pain because there's no good way to pick
> a name for the new file. I tried test/lisp/indentation-tests.el, but
> then the Makefile wants to find a dependency lisp/indentation.el. I
> wanted to choose a name that *wasn't* the same as any other existing
> lisp file, because this test crosses file boundaries.
>
> Any advice?
How about picking up a name of an existing source file that is somehow
related to the tests?
If that's not good enough, I think we need some new infrastructure for
this in test/Makefile, e.g. a way of specifying a rule that tells Make
which source files are prerequisites for the given test file, so that
when one of the prerequisites changes, the tests are automatically
run.
next prev parent reply other threads:[~2017-04-06 14:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-02 9:47 moving some indentation tests Tom Tromey
2017-04-02 11:46 ` Michael Albinus
2017-04-02 16:06 ` Tom Tromey
2017-04-02 18:16 ` Michael Albinus
2017-04-02 15:53 ` Eli Zaretskii
2017-04-02 15:58 ` Dmitry Gutov
2017-04-02 16:05 ` Tom Tromey
2017-04-02 20:31 ` Phillip Lord
2017-04-02 21:02 ` Noam Postavsky
2017-04-03 11:11 ` Phillip Lord
2017-04-03 13:20 ` Noam Postavsky
2017-04-03 16:39 ` Phillip Lord
2017-04-03 20:38 ` Noam Postavsky
2017-04-07 15:51 ` Phillip Lord
2017-04-07 16:06 ` Noam Postavsky
2017-04-06 3:28 ` Tom Tromey
2017-04-06 14:11 ` Eli Zaretskii [this message]
2017-04-06 14:32 ` Michael Albinus
2017-04-06 14:33 ` Noam Postavsky
2017-04-06 15:53 ` Tom Tromey
2017-04-07 15:54 ` Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fuhloccp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.