From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466) Date: Mon, 17 Apr 2017 17:35:38 +0300 Message-ID: <83fuh7drut.fsf@gnu.org> References: <20170412194437.19648.75020@vcs0.savannah.gnu.org> <20170412194438.934FD22EE8@vcs0.savannah.gnu.org> <87shldl1v8.fsf@localhost> <83h91sizcn.fsf@gnu.org> <87vaq79903.fsf@localhost> <83r30vh2k3.fsf@gnu.org> <83bmrwfg43.fsf@gnu.org> <8360i4f756.fsf@gnu.org> <8337d7fv9k.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1492439714 26765 195.159.176.226 (17 Apr 2017 14:35:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Apr 2017 14:35:14 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 17 16:35:11 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d07kD-0006rr-RO for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 16:35:09 +0200 Original-Received: from localhost ([::1]:36872 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d07kJ-00043j-QQ for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 10:35:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d07kE-000425-8N for emacs-devel@gnu.org; Mon, 17 Apr 2017 10:35:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d07kB-0004kT-5P for emacs-devel@gnu.org; Mon, 17 Apr 2017 10:35:10 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45753) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d07kB-0004jw-3X; Mon, 17 Apr 2017 10:35:07 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1579 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d07kA-0006JQ-99; Mon, 17 Apr 2017 10:35:06 -0400 In-reply-to: (message from Stefan Monnier on Mon, 17 Apr 2017 08:14:58 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214062 Archived-At: > From: Stefan Monnier > Date: Mon, 17 Apr 2017 08:14:58 -0400 > > >> By this measure, we can stop hacking on Emacs, > > Not hacking, only bike-shedding. > > To me bike-shedding means that it's only an aesthetic issue, but in this > case the ugliness has enough real consequences that you felt compelled > to document them via: The request for documenting the subtlety was voiced more than once over the years, and I saw no reason not to act on that. We document similar limitations and subtleties all over the place, so there's nothing extraordinary in this case. And I see no ugliness here, so if it exists, it must be minor. Thus it makes very little sense to me to insist on changing code that existed for several years because of some ugliness on whose existence we cannot even agree. > My patch (as fixed by Martin) fixes the problem instead of documenting > the resulting quirks. I think your patch involves some real, though perhaps minor, risk of breaking some code out there, and I don't think that risk is justified, given the (un)importance of the issue.