From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Fix quoted files for 'verify-visited-file-modtime'
Date: Wed, 26 Apr 2017 08:38:59 +0300
Message-ID: <83fugvpw24.fsf@gnu.org>
References: <CAArVCkRGXWZV0u-J0M5RrGf+mmGXgNZ8B2gx7OzxN6MbE_7mKg@mail.gmail.com>
	<20170423170607.10650-1-phst@google.com>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: blaine.gmane.org
X-Trace: blaine.gmane.org 1493185218 22612 195.159.176.226 (26 Apr 2017 05:40:18 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Wed, 26 Apr 2017 05:40:18 +0000 (UTC)
Cc: phst@google.com, emacs-devel@gnu.org
To: Philipp Stephani <p.stephani2@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 26 07:40:14 2017
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by blaine.gmane.org with esmtp (Exim 4.84_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1d3FgU-0005iS-9w
	for ged-emacs-devel@m.gmane.org; Wed, 26 Apr 2017 07:40:14 +0200
Original-Received: from localhost ([::1]:52732 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1d3FgX-0001pp-0s
	for ged-emacs-devel@m.gmane.org; Wed, 26 Apr 2017 01:40:17 -0400
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38241)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1d3Fg1-0001ph-B8
	for emacs-devel@gnu.org; Wed, 26 Apr 2017 01:39:46 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1d3Fg0-00078A-G8
	for emacs-devel@gnu.org; Wed, 26 Apr 2017 01:39:45 -0400
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49401)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1d3Ffu-00075j-Qr; Wed, 26 Apr 2017 01:39:38 -0400
Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3419
	helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1d3Ffu-0005Di-1U; Wed, 26 Apr 2017 01:39:38 -0400
In-reply-to: <20170423170607.10650-1-phst@google.com> (message from Philipp
	Stephani on Sun, 23 Apr 2017 19:06:07 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:214295
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/214295>

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sun, 23 Apr 2017 19:06:07 +0200
> Cc: Philipp Stephani <phst@google.com>
> 
> +  (with-temp-buffer
> +    (let* ((buffer-file-name "/:/tmp/bug25951.txt")

Please don't use file names that make assumptions about the underlying
filesystem structure.  I think our convention for files created by the
test suite to use make-temp-file.  Is there any reason this test
couldn't do the same?

Thanks.