all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: phst@google.com, emacs-devel@gnu.org
Subject: Re: [PATCH] Fix quoted files for 'verify-visited-file-modtime'
Date: Wed, 26 Apr 2017 08:38:59 +0300	[thread overview]
Message-ID: <83fugvpw24.fsf@gnu.org> (raw)
In-Reply-To: <20170423170607.10650-1-phst@google.com> (message from Philipp Stephani on Sun, 23 Apr 2017 19:06:07 +0200)

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sun, 23 Apr 2017 19:06:07 +0200
> Cc: Philipp Stephani <phst@google.com>
> 
> +  (with-temp-buffer
> +    (let* ((buffer-file-name "/:/tmp/bug25951.txt")

Please don't use file names that make assumptions about the underlying
filesystem structure.  I think our convention for files created by the
test suite to use make-temp-file.  Is there any reason this test
couldn't do the same?

Thanks.



  reply	other threads:[~2017-04-26  5:38 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03 13:56 bug#25951: 26.0.50; Error when ediffing files that are visited using quoted file names Philipp Stephani
2017-04-21 22:14 ` Philipp Stephani
2017-04-21 22:50   ` npostavs
2017-04-22 19:43     ` Philipp Stephani
2017-04-22 20:32       ` npostavs
2017-04-23 16:54         ` Philipp Stephani
2017-04-23 17:06           ` [PATCH] Fix quoted files for 'verify-visited-file-modtime' Philipp Stephani
2017-04-26  5:38             ` Eli Zaretskii [this message]
2017-04-29 12:20               ` Philipp Stephani
2017-05-06 19:27                 ` bug#25951: " Philipp
2017-05-06 19:27                 ` Philipp
2017-05-06 20:28                   ` bug#25951: " Glenn Morris
2017-05-06 20:41                     ` npostavs
2017-05-06 21:21                       ` bug#25951: [PATCH] Fix bootstrap build of files.el Philipp
2017-05-06 21:21                       ` Philipp
2017-05-07  1:24                         ` Glenn Morris
2017-05-07 11:35                           ` Philipp
2017-05-07 11:35                           ` bug#25951: " Philipp
2017-05-07  1:24                         ` Glenn Morris
2017-05-06 21:27                       ` bug#25951: [PATCH] Fix quoted files for 'verify-visited-file-modtime' Philipp
2017-04-29 12:20               ` Philipp Stephani
2017-04-29 11:49           ` Philipp Stephani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fugvpw24.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=p.stephani2@gmail.com \
    --cc=phst@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.