From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#26961: 26.0.50; Possible timming issue in regex-tests.el Date: Sat, 20 May 2017 13:04:38 +0300 Message-ID: <83fufzq1xl.fsf@gnu.org> References: <87inkz23aw.fsf@calancha-pc> <878tlvy4d4.fsf@calancha-pc> <83bmqr5trb.fsf@gnu.org> <874lwi3b00.fsf@calancha-pc> <83ziea4358.fsf@gnu.org> <87h90hwmip.fsf@calancha-pc> <837f1d48uc.fsf@gnu.org> <87shk113gf.fsf@calancha-pc> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1495274783 30026 195.159.176.226 (20 May 2017 10:06:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 20 May 2017 10:06:23 +0000 (UTC) Cc: 26961@debbugs.gnu.org, schwab@suse.de To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 20 12:06:16 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dC1H3-0007Z0-D5 for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 May 2017 12:06:13 +0200 Original-Received: from localhost ([::1]:33640 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dC1H5-0003dr-Op for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 May 2017 06:06:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dC1Gx-0003dK-LX for bug-gnu-emacs@gnu.org; Sat, 20 May 2017 06:06:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dC1Gt-0006vc-1x for bug-gnu-emacs@gnu.org; Sat, 20 May 2017 06:06:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53353) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dC1Gs-0006vO-OQ for bug-gnu-emacs@gnu.org; Sat, 20 May 2017 06:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dC1Gs-0003gr-F1 for bug-gnu-emacs@gnu.org; Sat, 20 May 2017 06:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 May 2017 10:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26961 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26961-submit@debbugs.gnu.org id=B26961.149527471114107 (code B ref 26961); Sat, 20 May 2017 10:06:02 +0000 Original-Received: (at 26961) by debbugs.gnu.org; 20 May 2017 10:05:11 +0000 Original-Received: from localhost ([127.0.0.1]:56023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dC1G3-0003fT-4U for submit@debbugs.gnu.org; Sat, 20 May 2017 06:05:11 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dC1G1-0003fG-VB for 26961@debbugs.gnu.org; Sat, 20 May 2017 06:05:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dC1Fv-0006lx-Rt for 26961@debbugs.gnu.org; Sat, 20 May 2017 06:05:04 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dC1Fp-0006lJ-Aa; Sat, 20 May 2017 06:04:57 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1714 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dC1Fo-0001wQ-JW; Sat, 20 May 2017 06:04:57 -0400 In-reply-to: <87shk113gf.fsf@calancha-pc> (message from Tino Calancha on Fri, 19 May 2017 20:38:40 +0900) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132666 Archived-At: > From: Tino Calancha > Cc: 26961@debbugs.gnu.org, schwab@suse.de, tino.calancha@gmail.com > Date: Fri, 19 May 2017 20:38:40 +0900 > > Eli Zaretskii writes: > > >> + AUTO_STRING (inner_format, "`?%c'"); > >> CALLN (Fmessage, > >> format, file, > >> - Fmapconcat (Qstring, > >> + Fmapconcat (list3 (Qlambda, list1 (Qchar), > >> + list3 (Qformat, inner_format, Qchar)), > >> Fsort (Vlread_unescaped_character_literals, Qlss), > >> separator)); > >> } > >> > >> Do you think this code is wrong? > > > > This does indeed look dangerous: we are in effect consing Lisp data > > structures from stack-based Lisp objects, and then process them in a > > way that could leave some of them lying around when this function > > returns, and its stack becomes invalid. > > > > Can you present the evidence that caused you to suspect this > > particular change? Were the "unescaped character literals" warning > > displayed during the session which crashed? > Yes, such warning always appear in the crash session. Does the problem go away if you replace each AUTO_STRING in load_warn_unescaped_character_literals with build_string? IOW, instead of this: AUTO_STRING (separator, ", "); use this: Lisp_Object separator = build_string (", "); and similarly for all the other strings used in the CALLN call in load_warn_unescaped_character_literals.