From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27427: 26.0.50; Native line numbers lead to display error in company-mode popup Date: Sun, 25 Jun 2017 17:13:54 +0300 Message-ID: <83fueotasd.fsf@gnu.org> References: <611468a0-3115-813a-7347-d0c06e155831@web.de> <83vanrx5uo.fsf@gnu.org> <362a7d18-7f05-2e99-f8b3-41c353cf234f@yandex.ru> <83h8zawvih.fsf@gnu.org> <00f59a24-2d80-ca47-b6f3-3d219aa5aa3f@yandex.ru> <8360fqvz9x.fsf@gnu.org> <6aa4616d-79f7-db1b-c048-076a9a48596f@yandex.ru> <83tw39urzq.fsf@gnu.org> <4c4b873b-2bec-1c12-82f5-325b558bea93@yandex.ru> <83o9tgul6h.fsf@gnu.org> <49b431fd-aaa4-e7ca-06fc-7146a0a5692c@yandex.ru> <83a84zul0d.fsf@gnu.org> <513eca6f-998a-a937-76c4-7cf2fb0ff787@yandex.ru> <83wp81u8rz.fsf@gnu.org> <83shipthve.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1498400117 27227 195.159.176.226 (25 Jun 2017 14:15:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 25 Jun 2017 14:15:17 +0000 (UTC) Cc: alexanderm@web.de, 27427@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 25 16:15:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dP8Jf-0006cQ-JN for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Jun 2017 16:15:07 +0200 Original-Received: from localhost ([::1]:42754 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dP8Jk-0002oL-QO for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Jun 2017 10:15:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dP8Je-0002mV-8h for bug-gnu-emacs@gnu.org; Sun, 25 Jun 2017 10:15:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dP8Jb-0005ab-44 for bug-gnu-emacs@gnu.org; Sun, 25 Jun 2017 10:15:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34714) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dP8Ja-0005aD-W4 for bug-gnu-emacs@gnu.org; Sun, 25 Jun 2017 10:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dP8Ja-0006sN-O9 for bug-gnu-emacs@gnu.org; Sun, 25 Jun 2017 10:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Jun 2017 14:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27427-submit@debbugs.gnu.org id=B27427.149840005826361 (code B ref 27427); Sun, 25 Jun 2017 14:15:02 +0000 Original-Received: (at 27427) by debbugs.gnu.org; 25 Jun 2017 14:14:18 +0000 Original-Received: from localhost ([127.0.0.1]:37391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dP8Ir-0006r7-Ny for submit@debbugs.gnu.org; Sun, 25 Jun 2017 10:14:17 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dP8Iq-0006qg-8z for 27427@debbugs.gnu.org; Sun, 25 Jun 2017 10:14:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dP8Ii-0004ic-10 for 27427@debbugs.gnu.org; Sun, 25 Jun 2017 10:14:11 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dP8Ih-0004iW-U1; Sun, 25 Jun 2017 10:14:07 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2779 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dP8Ih-0002g2-4e; Sun, 25 Jun 2017 10:14:07 -0400 In-reply-to: (message from Dmitry Gutov on Sat, 24 Jun 2017 23:43:25 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133870 Archived-At: > Cc: alexanderm@web.de, 27427@debbugs.gnu.org > From: Dmitry Gutov > Date: Sat, 24 Jun 2017 23:43:25 +0300 > > On 6/24/17 8:28 PM, Eli Zaretskii wrote: > > > Now done. Please see if this allows company-mode to fix its display > > when line numbers are displayed. > > Seems to work well locally, aside from the EOB case (*). Will commit > after you push to master. Great, thanks for testing. > BTW, without this property, I now see line numbers beside all the visual > lines the popup overlay takes up, and the number is the same: N+1, where > N is the line-at-point. That doesn't look intended. The displayed line number reflects the line of the buffer positions corresponding to what's on that screen line. If none of the buffer positions appear on that screen line, it's the line of the buffer position(s) "covered" by the display string/overlay which generates the display. If what you see doesn't fit this description, please show a screenshot, and describe or show the code which puts the overlay that causes the display. > (*) The case is where the overlay is shown below the last line of the > buffer. In that case, we display the popup using the `after-string' > property. The after-EOB glyphs don't seem to be affected by > `display-line-numbers-disable'. I'm not sure I understand: are you saying that you've put the property in that case and it didn't have the expected effect? Or are you saying that you don't have a position to put the property in that case? If the former, can you tell on which buffer position you put the property, and perhaps show a simple reproducer? Thanks.