From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28814: [BUMP, PATCH] (26.0.90; When *xref* window is needed, original window-switching intent is lost ) Date: Wed, 25 Oct 2017 18:39:42 +0300 Message-ID: <83fua78ce9.fsf@gnu.org> References: <87infjm3p3.fsf@gmail.com> <871slyi3lk.fsf_-_@gmail.com> <87lgk22ryu.fsf@gmail.com> <87fua91vis.fsf@gmail.com> <13af136e-12fb-4e8d-81ff-63424b1e1943@yandex.ru> <83inf38dq2.fsf@gnu.org> <87k1zjs0xa.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1508946076 23892 195.159.176.226 (25 Oct 2017 15:41:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 25 Oct 2017 15:41:16 +0000 (UTC) Cc: 28814@debbugs.gnu.org, dgutov@yandex.ru To: joaotavora@gmail.com (=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?=) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 25 17:41:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7Nnq-0005VP-EP for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Oct 2017 17:41:10 +0200 Original-Received: from localhost ([::1]:48838 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7Nnx-0007E4-Ka for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Oct 2017 11:41:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7Nnl-0007A8-S7 for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2017 11:41:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e7Nni-0006m9-He for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2017 11:41:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53058) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e7Nni-0006lg-Dl for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2017 11:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e7Nni-0003Qy-4p for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2017 11:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Oct 2017 15:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28814 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28814-submit@debbugs.gnu.org id=B28814.150894600513126 (code B ref 28814); Wed, 25 Oct 2017 15:41:02 +0000 Original-Received: (at 28814) by debbugs.gnu.org; 25 Oct 2017 15:40:05 +0000 Original-Received: from localhost ([127.0.0.1]:33505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7Nmn-0003Pe-99 for submit@debbugs.gnu.org; Wed, 25 Oct 2017 11:40:05 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7Nml-0003P4-AX for 28814@debbugs.gnu.org; Wed, 25 Oct 2017 11:40:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e7Nmc-0005hE-OZ for 28814@debbugs.gnu.org; Wed, 25 Oct 2017 11:39:58 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7Nmc-0005h4-KY; Wed, 25 Oct 2017 11:39:54 -0400 Original-Received: from [176.228.60.248] (port=1167 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e7Nmc-0005Um-2U; Wed, 25 Oct 2017 11:39:54 -0400 In-reply-to: <87k1zjs0xa.fsf@gmail.com> (joaotavora@gmail.com) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138969 Archived-At: > From: joaotavora@gmail.com (João Távora) > Cc: Dmitry Gutov , 28814@debbugs.gnu.org > Date: Wed, 25 Oct 2017 16:27:13 +0100 > > > If so, then the easiest solution IMO would be to pop up one more > > window, i.e. behave as if the window displaying the XREF buffer didn't > > exist. That would both keep the contract of "C-x 4" and leave the > > XREF buffer visible. > > Yes, this is the default behaviour in the current patches. Good. Then I'm happy. As for when we can't pop up a new window: would it be okay to reuse the current window only in that (hopefully, rare) case? > > As for quitting the XREF buffer when it's no longer needed: how about > > 'q', like other similar modes do, or some variety thereof? "C-u RET" > > is too odd, almost outlandish in Emacs. > > ’q’ is already taken by ’quit-window’ in *xref* buffers. It quits the > window and does nothing else. I’m looking for a command that quits *and* > goes to the target. How about 'Q'? > Then let’s open a separate discussion on whether that behaviour should > become the default (I think it should). What behavior should become the default? The problem with binding this "quit and go to reference" function to RET is that it is unlike any other similar feature we have: RET usually selects the item, but does not quit any windows. > It’s a bugfix, so emacs-26. I'd need to see the patches in their last incarnation (if you already posted them, and nothing needs to be changed, a URL will be appreciated). In general, this changes user-visible behavior in non-trivial ways, so it's borderline between a bugfix and a new feature. But if the patches are small and simple enough, I guess they could be okay for emacs-26. Thanks.