From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29423: 27.0.50; ls-lisp does not handle -F switch properly Date: Fri, 24 Nov 2017 15:37:26 +0200 Message-ID: <83fu93ajc9.fsf@gnu.org> References: <87fu93yhdy.fsf@gmx.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1511530764 18038 195.159.176.226 (24 Nov 2017 13:39:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 24 Nov 2017 13:39:24 +0000 (UTC) Cc: 29423@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 24 14:39:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIECI-000421-Lb for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Nov 2017 14:39:14 +0100 Original-Received: from localhost ([::1]:49329 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eIECP-0007m3-V0 for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Nov 2017 08:39:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eIEC9-0007kt-Nt for bug-gnu-emacs@gnu.org; Fri, 24 Nov 2017 08:39:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eIEC6-0008Jm-CO for bug-gnu-emacs@gnu.org; Fri, 24 Nov 2017 08:39:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46148) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eIEC6-0008Jh-8I for bug-gnu-emacs@gnu.org; Fri, 24 Nov 2017 08:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eIEC6-0007Ss-2n for bug-gnu-emacs@gnu.org; Fri, 24 Nov 2017 08:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Nov 2017 13:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29423 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 29423-submit@debbugs.gnu.org id=B29423.151153068628633 (code B ref 29423); Fri, 24 Nov 2017 13:39:02 +0000 Original-Received: (at 29423) by debbugs.gnu.org; 24 Nov 2017 13:38:06 +0000 Original-Received: from localhost ([127.0.0.1]:54829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIEBB-0007Rl-Pe for submit@debbugs.gnu.org; Fri, 24 Nov 2017 08:38:05 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:56465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIEBA-0007RH-6s for 29423@debbugs.gnu.org; Fri, 24 Nov 2017 08:38:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eIEB1-0007pg-Oe for 29423@debbugs.gnu.org; Fri, 24 Nov 2017 08:37:58 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eIEB1-0007pb-Li; Fri, 24 Nov 2017 08:37:55 -0500 Original-Received: from [176.228.60.248] (port=2886 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eIEAz-00018Z-Jg; Fri, 24 Nov 2017 08:37:55 -0500 In-reply-to: <87fu93yhdy.fsf@gmx.de> (message from Michael Albinus on Fri, 24 Nov 2017 13:45:45 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140302 Archived-At: > From: Michael Albinus > Date: Fri, 24 Nov 2017 13:45:45 +0100 > > Goto the *scratch* buffer, and perform > > M-: (ls-lisp-insert-directory "/tmp/" '(?F) nil nil nil) > > Move the cursor into the string /tmp/, and perform > > M-x describe-char > > There is no text property 'dired-filename, as it should. > > The following patch seems to cure the problem. Run the same test, you > will see the text property 'dired-filename. > > > [2:text/plain Hide] > > diff --git a/lisp/ls-lisp.el b/lisp/ls-lisp.el > index caddc7f760..6765cc8dc9 100644 > --- a/lisp/ls-lisp.el > +++ b/lisp/ls-lisp.el > @@ -841,9 +841,7 @@ ls-lisp-format > " " > (ls-lisp-format-time file-attr time-index) > " " > - (if (not (memq ?F switches)) ; ls-lisp-classify already did that > - (propertize file-name 'dired-filename t) > - file-name) > + (propertize file-name 'dired-filename t) > (if (stringp file-type) ; is a symbolic link > (concat " -> " file-type)) > "\n" How come ls-lisp-classify doesn't propertize the file name in this case?