From: Eli Zaretskii <eliz@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 29423@debbugs.gnu.org
Subject: bug#29423: 27.0.50; ls-lisp does not handle -F switch properly
Date: Fri, 24 Nov 2017 15:37:26 +0200 [thread overview]
Message-ID: <83fu93ajc9.fsf@gnu.org> (raw)
In-Reply-To: <87fu93yhdy.fsf@gmx.de> (message from Michael Albinus on Fri, 24 Nov 2017 13:45:45 +0100)
> From: Michael Albinus <michael.albinus@gmx.de>
> Date: Fri, 24 Nov 2017 13:45:45 +0100
>
> Goto the *scratch* buffer, and perform
>
> M-: (ls-lisp-insert-directory "/tmp/" '(?F) nil nil nil)
>
> Move the cursor into the string /tmp/, and perform
>
> M-x describe-char
>
> There is no text property 'dired-filename, as it should.
>
> The following patch seems to cure the problem. Run the same test, you
> will see the text property 'dired-filename.
>
>
> [2:text/plain Hide]
>
> diff --git a/lisp/ls-lisp.el b/lisp/ls-lisp.el
> index caddc7f760..6765cc8dc9 100644
> --- a/lisp/ls-lisp.el
> +++ b/lisp/ls-lisp.el
> @@ -841,9 +841,7 @@ ls-lisp-format
> " "
> (ls-lisp-format-time file-attr time-index)
> " "
> - (if (not (memq ?F switches)) ; ls-lisp-classify already did that
> - (propertize file-name 'dired-filename t)
> - file-name)
> + (propertize file-name 'dired-filename t)
> (if (stringp file-type) ; is a symbolic link
> (concat " -> " file-type))
> "\n"
How come ls-lisp-classify doesn't propertize the file name in this
case?
next prev parent reply other threads:[~2017-11-24 13:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 12:45 bug#29423: 27.0.50; ls-lisp does not handle -F switch properly Michael Albinus
2017-11-24 13:37 ` Eli Zaretskii [this message]
2017-11-24 13:41 ` Michael Albinus
2017-11-24 14:56 ` Eli Zaretskii
2017-11-24 15:13 ` Michael Albinus
2017-11-24 15:47 ` Eli Zaretskii
2017-11-25 8:12 ` Eli Zaretskii
2017-11-25 8:59 ` Michael Albinus
2017-11-25 10:37 ` Eli Zaretskii
2017-11-24 16:30 ` Drew Adams
2017-11-24 16:56 ` Michael Albinus
2017-11-24 17:12 ` Drew Adams
2017-11-24 18:48 ` Michael Albinus
2017-11-24 19:28 ` Drew Adams
2017-11-24 19:51 ` Noam Postavsky
2017-11-24 20:27 ` Drew Adams
2017-11-24 20:37 ` Noam Postavsky
2017-11-24 20:51 ` Drew Adams
2017-11-24 17:02 ` Eli Zaretskii
2017-11-24 18:49 ` Michael Albinus
2017-11-24 19:52 ` Eli Zaretskii
2017-11-24 21:03 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fu93ajc9.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=29423@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.