bug#30075: etags misdetects ruby sharp-bang sequence

bug#30075: etags misdetects ruby sharp-bang sequence

[Dmitry Gutov]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

Here's a file that is parsed wrongly when it has no .rb extension. The 
sharp-bang sequence at the top looks correct to me.

Attaching both the input file and the generated tags file.

The problem is present both in emacs-26 and master.

[-- Attachment #2: BAD_TAGS --]
[-- Type: application/octet-stream, Size: 98 bytes --]

[-- Attachment #3: no_ext_ruby_test --]
[-- Type: text/plain, Size: 403 bytes --]

#!/usr/bin/env ruby

module SimpleCov
  module ResultMerger
    class << self
      def resultset_files
        Dir.glob()
      end

      def foo
        resultset_files.map do |path|
          begin
            JSON.parse(File.read(path))
          rescue
            {}
          end
        end
      end

      def resultset
        resultset_hashes.reduce({}, :merge)
      end
    end
  end
end

bug#30075: etags misdetects ruby sharp-bang sequence

[Eli Zaretskii]

> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Thu, 11 Jan 2018 02:36:55 +0300
> 
> Here's a file that is parsed wrongly when it has no .rb extension. The 
> sharp-bang sequence at the top looks correct to me.

No one taught etags the name(s) of the Ruby interpreter(s), and nobody
told it about the "#!/usr/bin/env FOO" way of specifying an interpreter.

Should be fixed now on the emacs-26 branch.

Thanks.

bug#30075: etags misdetects ruby sharp-bang sequence

[Dmitry Gutov]

On 1/11/18 7:39 PM, Eli Zaretskii wrote:

> No one taught etags the name(s) of the Ruby interpreter(s), and nobody
> told it about the "#!/usr/bin/env FOO" way of specifying an interpreter.
> 
> Should be fixed now on the emacs-26 branch.

Looks fixed, thank you!

bug#30075: etags misdetects ruby sharp-bang sequence

[Dmitry Gutov]

On 1/12/18 1:07 AM, Dmitry Gutov wrote:
> On 1/11/18 7:39 PM, Eli Zaretskii wrote:
> 
>> No one taught etags the name(s) of the Ruby interpreter(s), and nobody
>> told it about the "#!/usr/bin/env FOO" way of specifying an interpreter.
>>
>> Should be fixed now on the emacs-26 branch.
> 
> Looks fixed, thank you!

Closing.