From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30762: 27.0.50; Apparent regression in process.c caused by checking pty_flag before calling setsid Date: Sat, 10 Mar 2018 10:36:15 +0200 Message-ID: <83fu58uy2o.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1520671369 3148 195.159.176.226 (10 Mar 2018 08:42:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 10 Mar 2018 08:42:49 +0000 (UTC) Cc: 30762@debbugs.gnu.org, eggert@cs.ucla.edu To: Thomas Fitzsimmons Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 10 09:42:45 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eua5V-0000g9-4E for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Mar 2018 09:42:45 +0100 Original-Received: from localhost ([::1]:49727 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eua7W-000712-2R for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Mar 2018 03:44:50 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eua02-00019b-EV for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 03:37:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1euZzx-0003kk-TY for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 03:37:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45167) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1euZzx-0003kg-O3 for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 03:37:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1euZzx-0006Aq-Hd for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 03:37:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Mar 2018 08:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30762 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30762-submit@debbugs.gnu.org id=B30762.152067099123689 (code B ref 30762); Sat, 10 Mar 2018 08:37:01 +0000 Original-Received: (at 30762) by debbugs.gnu.org; 10 Mar 2018 08:36:31 +0000 Original-Received: from localhost ([127.0.0.1]:53064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euZzT-0006A1-HZ for submit@debbugs.gnu.org; Sat, 10 Mar 2018 03:36:31 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euZzS-00069n-3X for 30762@debbugs.gnu.org; Sat, 10 Mar 2018 03:36:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1euZzM-0003Zw-2x for 30762@debbugs.gnu.org; Sat, 10 Mar 2018 03:36:24 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52358) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euZzF-0003Wt-Q3; Sat, 10 Mar 2018 03:36:17 -0500 Original-Received: from [176.228.60.248] (port=2531 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1euZzD-0005n7-P6; Sat, 10 Mar 2018 03:36:16 -0500 In-reply-to: (message from Thomas Fitzsimmons on Fri, 09 Mar 2018 23:18:51 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144094 Archived-At: > From: Thomas Fitzsimmons > Date: Fri, 09 Mar 2018 23:18:51 -0500 > Cc: Paul Eggert > > master tip gets stuck in that while loop, whereas Emacs 25.1 is fine. > > If I print the contents of the buffer within the loop, it shows: > > Process ldapsearch stopped (tty output) > > I isolated the working-to-non-working transition to this commit: > > commit 8e5a769965313a7a1c42b5992ed24e8b0ea71ead > Author: Paul Eggert > Date: Tue Dec 6 23:41:45 2016 -0800 > > Clean out some IRIX cruft > > * etc/MACHINES: Remove obsolete discussion of IRIX. > * src/process.c (allocate_pty) [__sgi]: Remove SGI-specific code. > (create_process) [HAVE_PTYS]: Don't worry about IRIX. > * src/syntax.c (scan_sexps_forward): Remove obsolete comment. > * src/unexelf.c [__sgi]: Don't include . > (unexec) [__sgi]: Remove SGI-specific code. > > and specifically the addition of this check in src/process.c: > > - /* We tried doing setsid only if pty_flag, but it caused > - process_set_signal to fail on SGI when using a pipe. */ > - setsid (); > + if (pty_flag) > + setsid (); > > If I remove the if (pty_flag) line, then eudc-expand-inline works again. This change is on the emacs-26 branch as well, so if we want to restore previous code, we should do it on emacs-26, not only on master. Thanks.