From: Eli Zaretskii <eliz@gnu.org>
To: Thomas Fitzsimmons <fitzsim@fitzsim.org>
Cc: 30762@debbugs.gnu.org, eggert@cs.ucla.edu
Subject: bug#30762: 27.0.50; Apparent regression in process.c caused by checking pty_flag before calling setsid
Date: Sat, 10 Mar 2018 10:36:15 +0200 [thread overview]
Message-ID: <83fu58uy2o.fsf@gnu.org> (raw)
In-Reply-To: <m3k1ukef6c.fsf@fitzsim.org> (message from Thomas Fitzsimmons on Fri, 09 Mar 2018 23:18:51 -0500)
> From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
> Date: Fri, 09 Mar 2018 23:18:51 -0500
> Cc: Paul Eggert <eggert@cs.ucla.edu>
>
> master tip gets stuck in that while loop, whereas Emacs 25.1 is fine.
>
> If I print the contents of the buffer within the loop, it shows:
>
> Process ldapsearch stopped (tty output)
>
> I isolated the working-to-non-working transition to this commit:
>
> commit 8e5a769965313a7a1c42b5992ed24e8b0ea71ead
> Author: Paul Eggert <eggert@cs.ucla.edu>
> Date: Tue Dec 6 23:41:45 2016 -0800
>
> Clean out some IRIX cruft
>
> * etc/MACHINES: Remove obsolete discussion of IRIX.
> * src/process.c (allocate_pty) [__sgi]: Remove SGI-specific code.
> (create_process) [HAVE_PTYS]: Don't worry about IRIX.
> * src/syntax.c (scan_sexps_forward): Remove obsolete comment.
> * src/unexelf.c [__sgi]: Don't include <syms.h>.
> (unexec) [__sgi]: Remove SGI-specific code.
>
> and specifically the addition of this check in src/process.c:
>
> - /* We tried doing setsid only if pty_flag, but it caused
> - process_set_signal to fail on SGI when using a pipe. */
> - setsid ();
> + if (pty_flag)
> + setsid ();
>
> If I remove the if (pty_flag) line, then eudc-expand-inline works again.
This change is on the emacs-26 branch as well, so if we want to
restore previous code, we should do it on emacs-26, not only on
master.
Thanks.
next prev parent reply other threads:[~2018-03-10 8:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-10 4:18 bug#30762: 27.0.50; Apparent regression in process.c caused by checking pty_flag before calling setsid Thomas Fitzsimmons
2018-03-10 8:36 ` Eli Zaretskii [this message]
2018-03-11 2:33 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fu58uy2o.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=30762@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=fitzsim@fitzsim.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.