From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: rogers@modulargenetics.com, 22978@debbugs.gnu.org
Subject: bug#22978: 25.0.92; log-view-diff: TMM required for non-consecutive revisions
Date: Wed, 20 Jun 2018 19:25:17 +0300 [thread overview]
Message-ID: <83fu1hs9w2.fsf@gnu.org> (raw)
In-Reply-To: <87muvqrtt2.fsf@gmail.com> (message from Noam Postavsky on Wed, 20 Jun 2018 00:00:25 -0400)
> From: Noam Postavsky <npostavs@gmail.com>
> Date: Wed, 20 Jun 2018 00:00:25 -0400
> Cc: 22978@debbugs.gnu.org
>
> > The patch included at the bottom restores the original behavior for us
> > non-TMM users while keeping TMM behavior.
>
> Not sure if it makes sense to change this.
My problem with the change is that there seems to be no escape from
it. And since in any buffer, the mark gets set pretty soon after one
starts to move around, it means users who turn off transient-mark-mode
will have no reasonable way of diffing the revision at point with the
previous one. By contrast, the current behavior allows you to get
diffs between revisions at region edges by "C-SPC C-SPC" etc.
next prev parent reply other threads:[~2018-06-20 16:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 17:12 bug#22978: 25.0.92; log-view-diff: TMM required for non-consecutive revisions Bob Rogers
2018-06-20 4:00 ` Noam Postavsky
2018-06-20 16:25 ` Eli Zaretskii [this message]
2018-06-27 20:04 ` Bob Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fu1hs9w2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=22978@debbugs.gnu.org \
--cc=npostavs@gmail.com \
--cc=rogers@modulargenetics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.