From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: patch gud-gdb to respect other-frame-window? Date: Sun, 29 Jul 2018 20:30:44 +0300 Message-ID: <83fu02q797.fsf@gnu.org> References: <86muuaq7m8.fsf@stephe-leake.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1532885353 1057 195.159.176.226 (29 Jul 2018 17:29:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 29 Jul 2018 17:29:13 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 29 19:29:09 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjpVF-0000Bc-2F for ged-emacs-devel@m.gmane.org; Sun, 29 Jul 2018 19:29:09 +0200 Original-Received: from localhost ([::1]:49181 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjpXL-0007sH-GD for ged-emacs-devel@m.gmane.org; Sun, 29 Jul 2018 13:31:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjpWk-0007sA-M4 for emacs-devel@gnu.org; Sun, 29 Jul 2018 13:30:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjpWh-0006Tu-J3 for emacs-devel@gnu.org; Sun, 29 Jul 2018 13:30:42 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42821) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjpWh-0006Tm-Es; Sun, 29 Jul 2018 13:30:39 -0400 Original-Received: from [176.228.60.248] (port=4158 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fjpWg-0005vT-Q7; Sun, 29 Jul 2018 13:30:39 -0400 In-reply-to: <86muuaq7m8.fsf@stephe-leake.org> (message from Stephen Leake on Sun, 29 Jul 2018 12:22:55 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227953 Archived-At: > From: Stephen Leake > Date: Sun, 29 Jul 2018 12:22:55 -0500 > > diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el > index 6826674a94..1b5cf46231 100644 > --- a/lisp/progmodes/gud.el > +++ b/lisp/progmodes/gud.el > @@ -2608,9 +2608,11 @@ gud-common-init > (select-window > (display-buffer > (get-buffer-create (concat "*gud" filepart "*")) > - '(display-buffer-reuse-window > - display-buffer-in-previous-window > - display-buffer-same-window display-buffer-pop-up-window))) > + (if (featurep 'other-frame-window) > + '(display-buffer-same-window) > + '(display-buffer-reuse-window > + display-buffer-in-previous-window > + display-buffer-same-window display-buffer-pop-up-window)))) > (when (and existing-buffer (get-buffer-process existing-buffer)) > (error "This program is already being debugged")) > ;; Set the dir, in case the buffer already existed with a different dir. > > A similar pattern can be used for other commands that do not currently > respect other-frame-window. > > Ok to commit to master? Isn't there a more elegant way of doing this, without asking about a feature explicitly? Maybe other-frame-window needs some enhancement to allow such protocols, otherwise we will need to test for each similar feature by name, and that is both inelegant and a maintenance burden, as both Emacs and those packages continue to evolve. Thanks.