From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Making 'eq' == 'eql' in bignum branch Date: Mon, 20 Aug 2018 19:23:55 +0300 Message-ID: <83ftz9dn1g.fsf@gnu.org> References: <29f933ac-a6bf-8742-66a7-0a9d6d3e5a88@disroot.org> <49d8ba62-c9a5-9203-d882-8e900b441ff3@cs.ucla.edu> <8e0320d9-e0d0-2b57-57cc-2df4399f133c@cs.ucla.edu> <87lgaio7xd.fsf@tromey.com> <877em1cb0i.fsf@tromey.com> <765767b2-d2e5-a9a6-f724-d58ecf4847bb@cs.ucla.edu> <76081b5d-8c10-0a37-2c97-d4864c0faa80@cs.ucla.edu> <09153aed-361d-4f82-d9ac-b502314769ae@cs.ucla.edu> <83lg91dqd4.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1534782124 25143 195.159.176.226 (20 Aug 2018 16:22:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 20 Aug 2018 16:22:04 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 20 18:22:00 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frmwJ-0006Nq-Re for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2018 18:21:59 +0200 Original-Received: from localhost ([::1]:48098 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frmyQ-0000QR-75 for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2018 12:24:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frmyJ-0000QM-L3 for emacs-devel@gnu.org; Mon, 20 Aug 2018 12:24:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frmyF-0001fz-BB for emacs-devel@gnu.org; Mon, 20 Aug 2018 12:24:03 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37265) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frmyE-0001fr-W0; Mon, 20 Aug 2018 12:23:59 -0400 Original-Received: from [176.228.60.248] (port=4420 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1frmyE-00064w-Jh; Mon, 20 Aug 2018 12:23:58 -0400 In-reply-to: (message from Stefan Monnier on Mon, 20 Aug 2018 11:37:01 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228740 Archived-At: > From: Stefan Monnier > Date: Mon, 20 Aug 2018 11:37:01 -0400 > > >> I think references to most-positive-fixnum (and implicit ones, like > >> using Frandom without an argument) should be eliminated. Fixnum range > >> is now an implementation detail. > > That is too radical, IMO. > > I think what Pip is saying is that we should review all *uses* of > most-positive-fixnum, because it's very likely that many/most of them > are now wrong or suboptimal. > > That doesn't mean we should remove most-positive-fixnum itself. I didn't think he meant to remove it. But the goal of eliminating references to it can only go so far, because there are legitimate use cases for referencing it. References that are no longer needed should be removed, but this is a case by case decision, and sometimes a judgment call, not an absolute requirement that Pip's wording hinted at.