From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33990: 27.0.50; image-transform-fit-to-height/-width violates assert Date: Sat, 12 Jan 2019 13:45:50 +0200 Message-ID: <83fttyf6a9.fsf@gnu.org> References: <875zv3m2xd.fsf@turtle-trading.net> <83a7kf0y6w.fsf@gnu.org> <87lg3yno9e.fsf@turtle-trading.net> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1547293529 22867 195.159.176.226 (12 Jan 2019 11:45:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 12 Jan 2019 11:45:29 +0000 (UTC) Cc: 33990@debbugs.gnu.org To: Benjamin Riefenstahl Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 12 12:45:25 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1giHjB-0005nN-0s for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Jan 2019 12:45:25 +0100 Original-Received: from localhost ([127.0.0.1]:55374 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giHlI-0002Eh-0Y for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Jan 2019 06:47:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giHkp-00026B-9h for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2019 06:47:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1giHkn-00015z-9a for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2019 06:47:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57304) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1giHkk-000152-4b for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2019 06:47:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1giHkj-0003kh-W7 for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2019 06:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Jan 2019 11:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33990 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33990-submit@debbugs.gnu.org id=B33990.154729357714331 (code B ref 33990); Sat, 12 Jan 2019 11:47:01 +0000 Original-Received: (at 33990) by debbugs.gnu.org; 12 Jan 2019 11:46:17 +0000 Original-Received: from localhost ([127.0.0.1]:56582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1giHk0-0003j4-6A for submit@debbugs.gnu.org; Sat, 12 Jan 2019 06:46:16 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38905) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1giHjy-0003iq-Gg for 33990@debbugs.gnu.org; Sat, 12 Jan 2019 06:46:15 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giHjt-0000je-BB; Sat, 12 Jan 2019 06:46:09 -0500 Original-Received: from [176.228.60.248] (port=2336 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1giHjs-00015j-VG; Sat, 12 Jan 2019 06:46:09 -0500 In-reply-to: <87lg3yno9e.fsf@turtle-trading.net> (message from Benjamin Riefenstahl on Sun, 06 Jan 2019 10:12:13 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154377 Archived-At: > From: Benjamin Riefenstahl > Cc: 33990@debbugs.gnu.org > Date: Sun, 06 Jan 2019 10:12:13 +0100 > > Eli Zaretskii writes: > > Please show the error message and the Lisp backtrace from the error, > > and also the values of the relevant variables. > > Values: > > size -> (995 . 1068) ; From image-display-size, i.e. the image dimensions > (window-inside-pixel-edges) -> (8 0 933 970) > > And yes, the image is actually higher than the window, it can be > scrolled. The original image is rather small, 75x80, and the > difference, 1068 - 970 -> 98, is about the size of an original pixel > after transformation, so this looks like a rounding problem. Maybe the > code should adjust by one original pixel when it calculates the target > height in image-transform-properties? Looks like your analysis is correct, thanks. Can you propose a patch that would implement your suggestion?