From: Eli Zaretskii <eliz@gnu.org>
To: Benjamin Riefenstahl <b.riefenstahl@turtle-trading.net>
Cc: 33990@debbugs.gnu.org
Subject: bug#33990: 27.0.50; image-transform-fit-to-height/-width violates assert
Date: Sat, 12 Jan 2019 13:45:50 +0200 [thread overview]
Message-ID: <83fttyf6a9.fsf@gnu.org> (raw)
In-Reply-To: <87lg3yno9e.fsf@turtle-trading.net> (message from Benjamin Riefenstahl on Sun, 06 Jan 2019 10:12:13 +0100)
> From: Benjamin Riefenstahl <b.riefenstahl@turtle-trading.net>
> Cc: 33990@debbugs.gnu.org
> Date: Sun, 06 Jan 2019 10:12:13 +0100
>
> Eli Zaretskii writes:
> > Please show the error message and the Lisp backtrace from the error,
> > and also the values of the relevant variables.
>
> Values:
>
> size -> (995 . 1068) ; From image-display-size, i.e. the image dimensions
> (window-inside-pixel-edges) -> (8 0 933 970)
>
> And yes, the image is actually higher than the window, it can be
> scrolled. The original image is rather small, 75x80, and the
> difference, 1068 - 970 -> 98, is about the size of an original pixel
> after transformation, so this looks like a rounding problem. Maybe the
> code should adjust by one original pixel when it calculates the target
> height in image-transform-properties?
Looks like your analysis is correct, thanks. Can you propose a patch
that would implement your suggestion?
next prev parent reply other threads:[~2019-01-12 11:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-05 17:26 bug#33990: 27.0.50; image-transform-fit-to-height/-width violates assert Benjamin Riefenstahl
2019-01-05 18:13 ` Eli Zaretskii
2019-01-06 9:12 ` Benjamin Riefenstahl
2019-01-12 11:45 ` Eli Zaretskii [this message]
2019-01-14 18:40 ` Benjamin Riefenstahl
2019-01-14 18:53 ` Eli Zaretskii
2019-01-15 21:38 ` Benjamin Riefenstahl
2019-01-19 8:29 ` Eli Zaretskii
2019-01-19 17:21 ` Benjamin Riefenstahl
2019-01-25 8:33 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fttyf6a9.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=33990@debbugs.gnu.org \
--cc=b.riefenstahl@turtle-trading.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.