From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36263: Fixed in master Date: Mon, 17 Jun 2019 20:36:48 +0300 Message-ID: <83fto8t8pb.fsf@gnu.org> References: <83muigtexp.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="201433"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36263@debbugs.gnu.org To: p.stephani2@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 17 19:44:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcvg5-000qHe-T4 for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Jun 2019 19:44:22 +0200 Original-Received: from localhost ([::1]:50564 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcvg4-0002uj-U6 for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Jun 2019 13:44:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46911) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcvZ3-0005qv-K6 for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2019 13:37:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcvZ2-0003lP-AL for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2019 13:37:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57937) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hcvZ0-0003iu-Ce for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2019 13:37:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hcvZ0-00061U-8Z for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2019 13:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Jun 2019 17:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36263 X-GNU-PR-Package: emacs Original-Received: via spool by 36263-submit@debbugs.gnu.org id=B36263.156079300623131 (code B ref 36263); Mon, 17 Jun 2019 17:37:02 +0000 Original-Received: (at 36263) by debbugs.gnu.org; 17 Jun 2019 17:36:46 +0000 Original-Received: from localhost ([127.0.0.1]:43248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcvYk-000611-1C for submit@debbugs.gnu.org; Mon, 17 Jun 2019 13:36:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcvYh-00060n-FZ for 36263@debbugs.gnu.org; Mon, 17 Jun 2019 13:36:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53673) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hcvYc-000375-AP; Mon, 17 Jun 2019 13:36:38 -0400 Original-Received: from [176.228.60.248] (port=2656 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hcvYb-0001vP-Nv; Mon, 17 Jun 2019 13:36:38 -0400 In-reply-to: <83muigtexp.fsf@gnu.org> (message from Eli Zaretskii on Mon, 17 Jun 2019 18:22:10 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160740 Archived-At: > Date: Mon, 17 Jun 2019 18:22:10 +0300 > From: Eli Zaretskii > Cc: 36263@debbugs.gnu.org > > OTOH, I see the same assertion violation in Emacs 25.2, so this is far > from a new problem. > > On the third hand, this assertion compiles to nothing in a production > version, so a production version doesn't crash. > > Therefore, it sounds like it isn't important enough to fix this on the > release branch, unless I'm missing something. Actually, I think that assertion has an off-by-one error, it should be eassert (tlen >= file_name_as_directory_slop + 1); If I change it this way, the recipe finishes and returns an empty string. Does anyone see a problem with making such a change on master? (I still think that we don't need to make any changes on the release branch.) Thanks.