all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: p.stephani2@gmail.com
Cc: 36263@debbugs.gnu.org
Subject: bug#36263: Fixed in master
Date: Mon, 17 Jun 2019 20:36:48 +0300	[thread overview]
Message-ID: <83fto8t8pb.fsf@gnu.org> (raw)
In-Reply-To: <83muigtexp.fsf@gnu.org> (message from Eli Zaretskii on Mon, 17 Jun 2019 18:22:10 +0300)

> Date: Mon, 17 Jun 2019 18:22:10 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 36263@debbugs.gnu.org
> 
> OTOH, I see the same assertion violation in Emacs 25.2, so this is far
> from a new problem.
> 
> On the third hand, this assertion compiles to nothing in a production
> version, so a production version doesn't crash.
> 
> Therefore, it sounds like it isn't important enough to fix this on the
> release branch, unless I'm missing something.

Actually, I think that assertion has an off-by-one error, it should be

  eassert (tlen >= file_name_as_directory_slop + 1);

If I change it this way, the recipe finishes and returns an empty
string.  Does anyone see a problem with making such a change on
master?  (I still think that we don't need to make any changes on the
release branch.)

Thanks.





  reply	other threads:[~2019-06-17 17:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17 12:23 bug#36263: 26.2.90; expand-file-name assertion failure if HOME is unset Philipp Stephani
2019-06-17 12:33 ` bug#36263: Fixed in master Philipp Stephani
2019-06-17 15:22   ` Eli Zaretskii
2019-06-17 17:36     ` Eli Zaretskii [this message]
2019-06-22  9:01       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fto8t8pb.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=36263@debbugs.gnu.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.