From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36431: Crash in marker.c:337 Date: Sun, 30 Jun 2019 17:39:49 +0300 Message-ID: <83ftnrf87e.fsf@gnu.org> References: <20190629.131734.877718102639559715.wl@gnu.org> <831rzch9nd.fsf@gnu.org> <83zhm0fuqg.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="18184"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36431@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 30 16:41:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hhb15-0004Vh-L2 for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Jun 2019 16:41:19 +0200 Original-Received: from localhost ([::1]:44972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhb0x-0007tk-Sk for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Jun 2019 10:41:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56912) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhb0q-0007tP-Ee for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 10:41:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhb0p-0008C7-E4 for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 10:41:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33534) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hhb0o-0008B2-To for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 10:41:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hhb0o-00050l-LA for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 10:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jun 2019 14:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36431 X-GNU-PR-Package: emacs Original-Received: via spool by 36431-submit@debbugs.gnu.org id=B36431.156190561019193 (code B ref 36431); Sun, 30 Jun 2019 14:41:02 +0000 Original-Received: (at 36431) by debbugs.gnu.org; 30 Jun 2019 14:40:10 +0000 Original-Received: from localhost ([127.0.0.1]:47078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhazy-0004zV-2t for submit@debbugs.gnu.org; Sun, 30 Jun 2019 10:40:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhazv-0004zF-Bx for 36431@debbugs.gnu.org; Sun, 30 Jun 2019 10:40:08 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hhazp-0006MN-69; Sun, 30 Jun 2019 10:40:01 -0400 Original-Received: from [176.228.60.248] (port=3197 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hhazl-0008WL-JM; Sun, 30 Jun 2019 10:39:58 -0400 In-reply-to: (message from Stefan Monnier on Sat, 29 Jun 2019 18:56:53 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161883 Archived-At: > From: Stefan Monnier > Cc: wl@gnu.org, 36431@debbugs.gnu.org > Date: Sat, 29 Jun 2019 18:56:53 -0400 > > I don't really know how to reproduce your bug, but I think I have an > idea of what might be going on. > Can you try the patch below, to see if it fixes your problem? AFAICT, this patch moves the call to move_gap_both from a fragment where we must decode the inserted text to a fragment where such a decoding might not be necessary. If I'm right, then this makes insert-file-contents slower in some cases, because moving the gap might be very expensive with large buffers. More generally, I'd be leery to make significant changes ion insert-file-contents just to placate that single assertion. What do we gain with that assertion except some theoretical correctness? OTOH, the losses, in stability, performance, and not least our time and energy is (or at least might be) real and tangible. So why bother?