From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: larsi@gnus.org, abliss@gmail.com, 36591@debbugs.gnu.org
Subject: bug#36591: 26.2; Term's pager seems broken
Date: Thu, 25 Jul 2019 16:11:15 +0300 [thread overview]
Message-ID: <83ftmuntsc.fsf@gnu.org> (raw)
In-Reply-To: <87ftmvvsol.fsf@gmail.com> (message from Noam Postavsky on Wed, 24 Jul 2019 20:55:38 -0400)
> From: Noam Postavsky <npostavs@gmail.com>
> Cc: Lars Ingebrigtsen <larsi@gnus.org>, abliss@gmail.com, 36591@debbugs.gnu.org
> Date: Wed, 24 Jul 2019 20:55:38 -0400
>
> > I would like to leave connect_network_socket alone on the release
> > branch, and just fix the problem with set-process-filter. I think the
> > easiest way is simply not to call set_process_filter_masks in
> > set-process-filter, and instead restore the way that code worked
> > before 9755b753, i.e. let it test the argument FILTER _before_ that
> > filter is installed. Do you see any problems with this fix?
>
> I think that makes sense, patch attached.
Thanks, this patch is OK for the emacs-26 branch.
> > On the master branch we should clean up the confusing set of if
> > clauses, both in set-process-filter and in connect_network_socket.
> > Perhaps Lars could describe his reasoning for making the change which
> > introduced set_process_filter_masks and what problem it tried to
> > solve. (Btw, the log message for that change seems to imply that
> > set-process-filter should not have called set_process_filter_masks,
> > something that the change itself disagrees with. An omission?)
>
> Hmm, true, I didn't pay that close attention to the log message.
> Maybe "we may not have a socket yet" refers to the already existing
> 'if (p->infd >= 0)' check?
Let's see what Lars remembers, and let's then take it from there.
next prev parent reply other threads:[~2019-07-25 13:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 0:06 bug#36591: 26.2; Term's pager seems broken Adam Bliss
2019-07-23 13:53 ` Noam Postavsky
2019-07-23 17:40 ` Eli Zaretskii
2019-07-23 22:33 ` Adam Bliss
2019-07-24 2:07 ` Noam Postavsky
2019-07-24 15:07 ` Eli Zaretskii
2019-07-25 0:55 ` Noam Postavsky
2019-07-25 10:02 ` Lars Ingebrigtsen
2019-07-25 13:01 ` Eli Zaretskii
2019-07-25 16:58 ` Lars Ingebrigtsen
2019-07-25 13:01 ` Noam Postavsky
2019-07-25 17:01 ` Lars Ingebrigtsen
2019-07-25 17:28 ` Noam Postavsky
2019-07-25 17:44 ` Lars Ingebrigtsen
2019-07-25 17:57 ` Noam Postavsky
2019-07-25 13:11 ` Eli Zaretskii [this message]
2019-07-25 22:38 ` Noam Postavsky
2020-08-21 12:58 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ftmuntsc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=36591@debbugs.gnu.org \
--cc=abliss@gmail.com \
--cc=larsi@gnus.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.