From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37006: 27.0.50; garbage collection not happening after 26de2d42 Date: Sun, 11 Aug 2019 20:07:15 +0300 Message-ID: <83ftm7tyv0.fsf@gnu.org> References: <5075406D-6DB8-4560-BB64-7198526FCF9F@acm.org> <24BB9DB5-D832-462F-A03C-5595A80B6973@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="58323"; mail-complaints-to="usenet@blaine.gmane.org" Cc: jrm@ftfl.ca, eggert@cs.ucla.edu, 37006@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 11 19:08:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hwrKC-000F1t-QD for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Aug 2019 19:08:08 +0200 Original-Received: from localhost ([::1]:41046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hwrKB-0005EZ-SP for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Aug 2019 13:08:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58220) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hwrK7-0005Dh-88 for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2019 13:08:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hwrK6-0005PM-Aj for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2019 13:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36931) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hwrK6-0005P9-7k for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2019 13:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hwrK5-0003kO-VR for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2019 13:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Aug 2019 17:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37006 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37006-submit@debbugs.gnu.org id=B37006.156554325914371 (code B ref 37006); Sun, 11 Aug 2019 17:08:01 +0000 Original-Received: (at 37006) by debbugs.gnu.org; 11 Aug 2019 17:07:39 +0000 Original-Received: from localhost ([127.0.0.1]:45752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hwrJj-0003jj-A0 for submit@debbugs.gnu.org; Sun, 11 Aug 2019 13:07:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hwrJi-0003jV-2Z for 37006@debbugs.gnu.org; Sun, 11 Aug 2019 13:07:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37036) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hwrJc-0004uM-9C; Sun, 11 Aug 2019 13:07:32 -0400 Original-Received: from [176.228.60.248] (port=2026 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hwrJb-0001Nn-N9; Sun, 11 Aug 2019 13:07:32 -0400 In-reply-to: <24BB9DB5-D832-462F-A03C-5595A80B6973@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Sun, 11 Aug 2019 18:23:28 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164891 Archived-At: > From: Mattias EngdegÄrd > Date: Sun, 11 Aug 2019 18:23:28 +0200 > Cc: Eli Zaretskii , Paul Eggert , > 37006@debbugs.gnu.org > > Observed on macOS as well. Reason: free_cons has the condition > > if (INT_ADD_WRAPV (consing_until_gc, sizeof *ptr, &consing_until_gc)) > > which will return true (overflow) if consing_until_gc is negative, which is kind of defensible since sizeof is unsigned which causes the sum (consing_until_gc + sizeof *ptr) to be a large unsigned number that doesn't fit into consing_until_gc. > > Clang 10 defines __GNUC__ to 4 which causes intprops.h to not use __builtin_add_overflow despite that being present and working. > > Casting the sizeof should fix it; patch attached. I believe it should be fixed now.