From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36867: 26.2; gamegrid-add-scrore miss lower-is-better flag Date: Sat, 14 Sep 2019 11:23:39 +0300 Message-ID: <83ftkzz3p0.fsf@gnu.org> References: <87a7cvukm9.fsf@pointsman.de> <8736hdf1z1.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="246181"; mail-complaints-to="usenet@blaine.gmane.org" Cc: rolf@pointsman.de, 36867-done@debbugs.gnu.org To: Federico Tedin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 14 10:24:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i93Ll-0011qw-VO for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Sep 2019 10:24:10 +0200 Original-Received: from localhost ([::1]:48992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i93Lk-0002g0-Qt for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Sep 2019 04:24:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34266) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i93Lf-0002fo-Ca for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2019 04:24:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i93Le-0003kr-3i for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2019 04:24:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37011) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i93Le-0003kh-1Q for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2019 04:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i93Ld-0008Ir-S5 for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2019 04:24:01 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Sep 2019 08:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 36867 X-GNU-PR-Package: emacs Mail-Followup-To: 36867@debbugs.gnu.org, eliz@gnu.org, rolf@pointsman.de Original-Received: via spool by 36867-done@debbugs.gnu.org id=D36867.156844941231852 (code D ref 36867); Sat, 14 Sep 2019 08:24:01 +0000 Original-Received: (at 36867-done) by debbugs.gnu.org; 14 Sep 2019 08:23:32 +0000 Original-Received: from localhost ([127.0.0.1]:45831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i93L9-0008Hg-SH for submit@debbugs.gnu.org; Sat, 14 Sep 2019 04:23:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i93L7-0008HO-MR for 36867-done@debbugs.gnu.org; Sat, 14 Sep 2019 04:23:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49032) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i93L2-0003bY-7W; Sat, 14 Sep 2019 04:23:24 -0400 Original-Received: from [176.228.60.248] (port=2398 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i93L1-0008PB-NB; Sat, 14 Sep 2019 04:23:24 -0400 In-reply-to: <8736hdf1z1.fsf@gmail.com> (message from Federico Tedin on Wed, 04 Sep 2019 00:29:22 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166429 Archived-At: > From: Federico Tedin > Date: Wed, 04 Sep 2019 00:29:22 +0200 > Cc: 36867@debbugs.gnu.org > > Rolf Ade writes: > > > The function gamegrid-add-scrore is handy for games developer; they get > > a high-score management system with one call. That includes a threshold > > for the number of entries in the high-score file. > > > > A consequence of that is, that an entry has be removed from the list if > > a new, better one must be inserted. In this situation, > > gamegrid-add-scrore currently always removes the "lowest" result. > > > > This is good and well for "more is better" games. But is wrong for > > "faster is better" games. An example: > > https://github.com/calancha/Minesweeper > > > > This feature omission is on lisp level. The in the emacs sources > > included tool update-game-score (which is used by gamegrid, if it is > > available) support reverse opperation. > > I've added a new 'reverse' parameter to gamegrid-add-score that allows > switching between storing the scores normally, or in reverse order. As > Rolf mentioned, this feature was already implemented in > update-game-score. I'm attaching a patch with my changes. Thanks, pushed to the master branch. In the future, please mark NEWS entries with "---" if they don't need to be described in the manuals, and with "+++" if the patch includes the changes for the manuals. (I did this for you this time.)