From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: set-frame-size should respect line-spacing!? Date: Sun, 13 Oct 2019 16:20:45 +0300 Message-ID: <83ftjwlr2q.fsf@gnu.org> References: <87blun57wt.fsf@kenko.localhost.com> <83o8ymo3cx.fsf@gnu.org> <877e5al9ny.fsf@kenko.localhost.com> <26dd3c24-f21d-bbef-a975-86318a8eaf80@gmx.at> <8336fynvq4.fsf@gnu.org> <1d1e1131-19ca-687c-8383-35a5fb8e3021@gmx.at> <83zhi6m7ls.fsf@gnu.org> <9b1761cd-5877-16b8-39a0-b68e20e4b0cb@gmx.at> <83pnj1ko44.fsf@gnu.org> <6b419874-269e-b15d-3bdf-ac68420b2197@gmx.at> <83imoslty4.fsf@gnu.org> <78f7d947-d17a-9d4a-8b8d-d07eed25c887@gmx.at> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="112169"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org, ingo.lohmar@posteo.net To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 13 15:21:43 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJdod-000T5H-3e for ged-emacs-devel@m.gmane.org; Sun, 13 Oct 2019 15:21:43 +0200 Original-Received: from localhost ([::1]:39536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJdob-0001th-ST for ged-emacs-devel@m.gmane.org; Sun, 13 Oct 2019 09:21:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44711) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJdnr-0001sg-0R for emacs-devel@gnu.org; Sun, 13 Oct 2019 09:20:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57638) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iJdnq-0001sd-Kr; Sun, 13 Oct 2019 09:20:54 -0400 Original-Received: from [176.228.60.248] (port=4966 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iJdnq-0000WM-1f; Sun, 13 Oct 2019 09:20:54 -0400 In-reply-to: <78f7d947-d17a-9d4a-8b8d-d07eed25c887@gmx.at> (message from martin rudalics on Sun, 13 Oct 2019 14:51:46 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240961 Archived-At: > Cc: ingo.lohmar@posteo.net, emacs-devel@gnu.org > From: martin rudalics > Date: Sun, 13 Oct 2019 14:51:46 +0200 > > >> Sorry for my insistence but 'window-resize' has nothing to do with the > >> frame size. > > > > But this discussion was about set-frame-size, at least that's what I > > thought. > > The 'set-frame-size' problem is inherently related to Bug#14825: Both > are about how to take line spacing and face remapping into account > when resizing windows. Just that the former affects the frame size as > well. And I was saying that we should be able to solve window-splitting and resizing use cases while leaving set-frame-size unaffected. > >> My concerns are that we call 'window--size-to-pixel' when > >> we resize or split a window. So if we want to special-code the split > >> window case and _not_ the 'window-resize' case, I have to either > >> special-code 'window--size-to-pixel' too or call some other function > >> instead. > > > > What is the window-resize case? > > That of how it should handle line spacing and face remapping when > resizing a window. For example, how should we relate the desired > height of a window to the value of 'window-min-height' when these are > in effect? I think the only case where the issues raised by bug#14825 should matter is when we decide whether a window is too small. E.g., what bad things will happen if we interpret window-min-height in terms of the default face's font set for the buffer shown (or to be shown) in the window?