From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: emacs-devel@gnu.org
Subject: Re: /* FIXME: Call signal_after_change! */ in callproc.c. Well, why not?
Date: Sun, 05 Jan 2020 20:17:44 +0200 [thread overview]
Message-ID: <83ftgtg43b.fsf@gnu.org> (raw)
In-Reply-To: <20200104224730.GB4009@ACM> (message from Alan Mackenzie on Sat, 4 Jan 2020 22:47:30 +0000)
> Date: Sat, 4 Jan 2020 22:47:30 +0000
> Cc: emacs-devel@gnu.org
> From: Alan Mackenzie <acm@muc.de>
>
> OK. I have to say here, I really don't believe such an extensive
> commentary is needed here. The code is there, and anybody generally
> familiar with our C code would understand it without a great deal of
> difficulty, even the mechanism which prevents a spurious second call to
> prepare_to_modify_buffer. Surely?
If you think this is a waste of effort, you can leave the commentary
to me.
> For each iteration of the enclosing while (1) loop which
> yields data (i.e. nread > 0), before- and
> after-change-functions are each invoked exactly once.
> This is done directly from the current function only, by
> calling prepare_to_modify_buffer and signal_after_change.
> It is never done by directing another function such as
> insert_1_both to call them.
The last sentence above is inaccurate, since insert_1_both does call
prepare_to_modify_buffer.
Thanks.
next prev parent reply other threads:[~2020-01-05 18:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-21 17:23 /* FIXME: Call signal_after_change! */ in callproc.c. Well, why not? Alan Mackenzie
2019-12-21 18:11 ` Eli Zaretskii
2019-12-21 21:47 ` Alan Mackenzie
2019-12-22 18:38 ` Eli Zaretskii
2019-12-24 9:47 ` Alan Mackenzie
2019-12-24 12:51 ` Alan Mackenzie
2019-12-24 15:58 ` Eli Zaretskii
2019-12-24 15:47 ` Eli Zaretskii
2019-12-29 13:34 ` Alan Mackenzie
2019-12-29 16:23 ` Stefan Monnier
2020-01-03 8:45 ` Eli Zaretskii
2020-01-04 22:47 ` Alan Mackenzie
2020-01-05 18:17 ` Eli Zaretskii [this message]
2020-01-05 18:48 ` Alan Mackenzie
2020-01-21 20:34 ` Alan Mackenzie
2020-01-22 3:27 ` Eli Zaretskii
2020-01-22 20:05 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ftgtg43b.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.