all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Andreas Schwab <schwab@linux-m68k.org>,
	Stefan Monnier <monnier@iro.umontreal.ca>
Cc: thibault@thb.lt, stefan@marxist.se, 38872@debbugs.gnu.org
Subject: bug#38872: 27.0.50; Keywords can be let-bound
Date: Fri, 17 Jan 2020 09:47:30 +0200	[thread overview]
Message-ID: <83ftge34od.fsf@gnu.org> (raw)
In-Reply-To: <871rrzmaik.fsf@igel.home> (message from Andreas Schwab on Thu, 16 Jan 2020 21:06:27 +0100)

> From: Andreas Schwab <schwab@linux-m68k.org>
> Date: Thu, 16 Jan 2020 21:06:27 +0100
> Cc: Thibault Polge <thibault@thb.lt>, 38872@debbugs.gnu.org
> 
> On Jan 16 2020, Stefan Kangas wrote:
> 
> > diff --git a/src/eval.c b/src/eval.c
> > index 4559a0e1f6..9a3f703f40 100644
> > --- a/src/eval.c
> > +++ b/src/eval.c
> > @@ -972,8 +972,11 @@ DEFUN ("let", Flet, Slet, 1, UNEVALLED, 0,
> >        if (!NILP (lexenv) && SYMBOLP (var)
> >  	  && !XSYMBOL (var)->u.s.declared_special
> >  	  && NILP (Fmemq (var, Vinternal_interpreter_environment)))
> > -	/* Lexically bind VAR by adding it to the lexenv alist.  */
> > -	lexenv = Fcons (Fcons (var, tem), lexenv);
> > +	if (XSYMBOL (var)->u.s.trapped_write == SYMBOL_NOWRITE)
> 
> I think that should use the same condition as set_internal, so that (let
> ((:k :k))) still works.

Adding Stefan Monnier to the discussion.  Stefan, any comments on this
issue?

Thanks.





  reply	other threads:[~2020-01-17  7:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-02 17:14 bug#38872: 27.0.50; Keywords can be let-bound Thibault Polge
2020-01-16 19:52 ` Stefan Kangas
2020-01-16 20:06   ` Andreas Schwab
2020-01-17  7:47     ` Eli Zaretskii [this message]
     [not found]     ` <87wo9r2fi6.fsf@marxist.se>
2020-01-17 14:11       ` Stefan Monnier
2020-09-20 10:36         ` Lars Ingebrigtsen
2020-09-20 10:55           ` Eli Zaretskii
2020-09-20 10:57             ` Lars Ingebrigtsen
2020-09-20 12:53           ` Stefan Monnier
2020-09-20 19:31             ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ftge34od.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=38872@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=schwab@linux-m68k.org \
    --cc=stefan@marxist.se \
    --cc=thibault@thb.lt \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.