From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: New multi-command facility displays in the wrong echo area. Date: Fri, 16 Oct 2020 10:19:02 +0300 Message-ID: <83ft6ewsd5.fsf@gnu.org> References: <20201009163445.GB4027@ACM> <20201009203810.GC4027@ACM> <83imbi609a.fsf@gnu.org> <20201010103233.GB5662@ACM> <834kn25o6b.fsf@gnu.org> <20201010124446.GC5662@ACM> <831ri65jpc.fsf@gnu.org> <83zh4u44mx.fsf@gnu.org> <83imbg4yl3.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5477"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 16 09:20:59 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTK2s-0001Jw-E8 for ged-emacs-devel@m.gmane-mx.org; Fri, 16 Oct 2020 09:20:58 +0200 Original-Received: from localhost ([::1]:34172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTK2r-0006Ui-Fu for ged-emacs-devel@m.gmane-mx.org; Fri, 16 Oct 2020 03:20:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTK18-0005p3-4d for emacs-devel@gnu.org; Fri, 16 Oct 2020 03:19:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42244) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTK16-0001aN-7a; Fri, 16 Oct 2020 03:19:08 -0400 Original-Received: from [176.228.60.248] (port=2900 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kTK13-0006at-6R; Fri, 16 Oct 2020 03:19:07 -0400 In-Reply-To: (message from Gregory Heytings on Wed, 14 Oct 2020 20:44:15 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:257781 Archived-At: > Date: Wed, 14 Oct 2020 20:44:15 +0000 > From: Gregory Heytings > cc: acm@muc.de, monnier@iro.umontreal.ca, emacs-devel@gnu.org > > I just realized (thanks to Stefan's last email on this list) that my patch > introduces a regression for those who (like him) use miniwindow-only > frames. > > To correct that regression, the third condition in set-minibuffer-message: > > (eq (window-frame) (window-frame (active-minibuffer-window)) > > should be: > > (or (eq (window-frame) (window-frame (active-minibuffer-window))) > (eq (frame-parameter (window-frame (active-minibuffer-window)) 'minibuffer) 'only))) > > It means: display the message at the end of the active minibuffer if it is > either on the same frame as the current window, or if it is in a > miniwindow-only frame. Thanks, I fixed this with a similar change.