From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height Date: Thu, 18 Mar 2021 22:05:02 +0200 Message-ID: <83ft0sfcsx.fsf@gnu.org> References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> <877dm4o6fj.fsf@tcd.ie> <83zgz0fqcs.fsf@gnu.org> <87mtv0lc53.fsf@tcd.ie> <87y2eko0js.fsf@mail.linkov.net> <83mtv0fgbu.fsf@gnu.org> <87v99owali.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21671"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, 47234@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 18 21:06:26 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMyuX-0005XF-QZ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Mar 2021 21:06:25 +0100 Original-Received: from localhost ([::1]:49484 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMyuW-000754-ST for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Mar 2021 16:06:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMyuA-00074M-T2 for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 16:06:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lMyuA-0000B7-0f for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 16:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lMyu9-00041G-RI for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 16:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Mar 2021 20:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47234 X-GNU-PR-Package: emacs Original-Received: via spool by 47234-submit@debbugs.gnu.org id=B47234.161609791315389 (code B ref 47234); Thu, 18 Mar 2021 20:06:01 +0000 Original-Received: (at 47234) by debbugs.gnu.org; 18 Mar 2021 20:05:13 +0000 Original-Received: from localhost ([127.0.0.1]:48148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMytN-000408-8M for submit@debbugs.gnu.org; Thu, 18 Mar 2021 16:05:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMytK-0003zs-QP for 47234@debbugs.gnu.org; Thu, 18 Mar 2021 16:05:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35021) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMytD-000846-EQ; Thu, 18 Mar 2021 16:05:03 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4233 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lMytC-0004fz-Ot; Thu, 18 Mar 2021 16:05:03 -0400 In-Reply-To: <87v99owali.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 18 Mar 2021 21:00:41 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202647 Archived-At: > From: Juri Linkov > Cc: contovob@tcd.ie, rudalics@gmx.at, 47234@debbugs.gnu.org > Date: Thu, 18 Mar 2021 21:00:41 +0200 > > >> Please note this should be fixed on the release branch in Emacs 27.2 > >> because the change in commit 6c5ddf0e0b was recently made in emacs-27. > > > > Why does it have to be done in Emacs 27.2? > > > > Please be aware that Emacs 27.2 is all but released at this point. > > Martin said that the commit 6c5ddf0e0b added recently in emacs-27 > should be reverted from Emacs 27.2. > > >> I wonder why only tab-bar-height was added to frame-inner-height, > >> why not menu-bar-height as well? Moreover, such function as > >> menu-bar-height doesn't exist at all. Why only tab-bar-height is needed? > > > > Maybe tab-bar-height is not needed in this case, either. We could > > instead modify the code that attempts to call it. > > Grepping shows that the only code that calls frame-inner-height > is mouse-drag-frame-resize. Thanks. After thinking some more about this, I think we should leave the frame.el part of 6c5ddf0e0b alone, but augment it with the fboundp test, such that on TTY frames the tab bar would be included in the frame's inner height, like the menu bar is. This is also consistent with what happens on TTY frames in a build with X: tab-bar-height returns zero. Basil, can you please install such a change on the emacs-27 branch? I will then make another RC.