From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default Date: Tue, 14 Sep 2021 14:46:51 +0300 Message-ID: <83fsu7crbo.fsf@gnu.org> References: <1df50c0d035675f851387d689030d588@purelymail.com> <87k0nw1qaq.fsf@red-bean.com> <878s4cf74z.fsf@gnus.org> <871r5semh0.fsf@gnus.org> <87v934tgi0.fsf@gmail.com> <87lf3zwgpi.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3177"; mail-complaints-to="usenet@ciao.gmane.io" Cc: kfogel@red-bean.com, stefan@marxist.se, pwr@bydasein.com, orontee@gmail.com, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 14 13:51:05 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQ6xs-0000eV-UA for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Sep 2021 13:51:04 +0200 Original-Received: from localhost ([::1]:38738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQ6xr-0003Lk-5r for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Sep 2021 07:51:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44132) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ6tx-000063-TG for emacs-devel@gnu.org; Tue, 14 Sep 2021 07:47:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49126) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQ6tv-0003Wx-Va; Tue, 14 Sep 2021 07:47:01 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4657 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ6tv-0000Mn-3C; Tue, 14 Sep 2021 07:46:59 -0400 In-Reply-To: <87lf3zwgpi.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 14 Sep 2021 13:15:53 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274691 Archived-At: > From: Lars Ingebrigtsen > Cc: Karl Fogel , Eli Zaretskii , "Paul > W. Rankin" , Stefan Kangas , "Paul > W. Rankin via Emacs development discussions." > Date: Tue, 14 Sep 2021 13:15:53 +0200 > > Matthias Meulien writes: > > > See the following attachment where two bookmark-fringe-mark are > > visible in the fringe (I just opened multiple bookmarks to *vc-dir* > > buffers where one bookmark doesn't point to the first line of the > > buffer): > > So the problem seems to be that a `revert-buffer' doesn't keep overlays > where they were, I guess? (Or remove the overlays, at least.) Are they removed, or do they move/evaporate because their markers move? > Do we have some machinery to handle overlays like this, or conventions > about what to do with overlays when doing a `revert-buffer' actions? AFAIK, we already try to preserve the buffer markers, if possible. And revert-buffer-with-fine-grain tries harder. So if the issue is that the overlays' markers moved, we already try.