all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: handa@gnu.org, 49797@debbugs.gnu.org
Subject: bug#49797: 28.0.50; Setting face to custom fontset doesn't work
Date: Fri, 08 Oct 2021 08:38:07 +0300	[thread overview]
Message-ID: <83fstcyt34.fsf@gnu.org> (raw)
In-Reply-To: <8B79C354-D63D-42F4-9910-72B3568315CD@gmail.com> (message from Yuan Fu on Thu, 7 Oct 2021 13:13:28 -0700)

> From: Yuan Fu <casouri@gmail.com>
> Date: Thu, 7 Oct 2021 13:13:28 -0700
> Cc: Kenichi Handa <handa@gnu.org>,
>  49797@debbugs.gnu.org
> 
> >>      if (face->ascii_face->font)
> >> 	{
> >> 	  XSETFONT (font_object, face->ascii_face->font);
> >> 	  if (font_has_char (f, font_object, c))
> >> 	    return face->ascii_face->id;
> >> 	}
> > 
> > No, this is where we try to use the ASCII font for symbols and
> > punctuation characters.
> 
> You are right.
> 
> > 
> >> And what about the comment I mentioned? Did you read it?
> > 
> > Yes, but it has no relevance to the issue at hand.  That whole part is
> > about displaying symbol and punctuation characters.
> 
> It IMO reveals the writer’s intent that fontset can be used to force a face to display certain characters with certain font.

I don't see how you arrived at that conclusion.  What the above
snippet does is simply check whether the face's font used for the
ASCII characters (which is the default font of the face) is capable of
displaying the given symbol or punctuation character, and if so, it
uses that default font instead of consulting the fontset (where symbol
and punctuation characters could be assigned to a different font).
There's no reference or usage of any fontset in this code snippet.





  reply	other threads:[~2021-10-08  5:38 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-31 21:37 bug#49797: 28.0.50; Setting face to custom fontset doesn't work Yuan Fu
2021-08-01  6:03 ` Eli Zaretskii
2021-08-01 15:18   ` Yuan Fu
2021-08-01 16:01     ` Eli Zaretskii
2021-08-01 16:27       ` Yuan Fu
2021-08-01 16:42         ` Eli Zaretskii
2021-08-02 11:57   ` handa
2021-08-02 17:14     ` Fu Yuan
2021-10-05 15:36       ` Yuan Fu
2021-10-05 16:12         ` Eli Zaretskii
2021-10-05 17:31           ` Yuan Fu
2021-10-05 19:01             ` Eli Zaretskii
2021-10-05 19:15               ` Yuan Fu
2021-10-05 19:18                 ` Eli Zaretskii
2021-10-05 19:26             ` Eli Zaretskii
2021-10-05 20:51               ` Yuan Fu
2021-10-06 16:10                 ` Eli Zaretskii
2021-10-06 18:11                   ` Yuan Fu
2021-10-06 18:33                     ` Eli Zaretskii
2021-10-06 18:56                       ` Yuan Fu
2021-10-06 19:02                         ` Eli Zaretskii
2021-10-07 20:13                           ` Yuan Fu
2021-10-08  5:38                             ` Eli Zaretskii [this message]
2021-10-08 19:35                               ` Yuan Fu
2022-08-22 10:35                                 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fstcyt34.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=49797@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=handa@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.