From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 6ed1994d27: Prevent crashes from illegal locale coding systems Date: Wed, 16 Feb 2022 14:22:37 +0200 Message-ID: <83fsoj2e7m.fsf@gnu.org> References: <83czjqrkew.fsf@gnu.org> <874k52kiu4.fsf@yahoo.com> <837d9yribj.fsf@gnu.org> <87v8xii83e.fsf@yahoo.com> <83r186p1h8.fsf@gnu.org> <878ruehx6n.fsf@yahoo.com> <83h791pmnl.fsf@gnu.org> <87iltheyeu.fsf@yahoo.com> <83wnhwol2o.fsf@gnu.org> <87tud0ybhj.fsf@yahoo.com> <837d9w450e.fsf@gnu.org> <87czjow7x1.fsf@yahoo.com> <8335kk440x.fsf@gnu.org> <87sfsjvdnm.fsf@yahoo.com> <87leybv8mp.fsf@yahoo.com> <87h78zv1hc.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35591"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 16 13:26:21 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKJO0-00099m-KI for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Feb 2022 13:26:20 +0100 Original-Received: from localhost ([::1]:55868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nKJNz-0006sc-Fu for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Feb 2022 07:26:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKJKO-0003m2-Rp for emacs-devel@gnu.org; Wed, 16 Feb 2022 07:22:36 -0500 Original-Received: from [2001:470:142:3::e] (port=50768 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKJKK-0006fr-Uj; Wed, 16 Feb 2022 07:22:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xzITvtiTSRjUVsUVTE6btttxsYcoPrhKaP30LyrkazE=; b=ltTNgg2+89Rm ouMG0HFAVNmU3pkVjMJe7AJDkrDOJfWBNYRzphz6pO5riiar7ff8qUBkJPSwToQhavT8x4DJcY1Zs r2YH0b0S0nLW8zi7j2q9Es5vlW9GavxMFsbYcEynYRlxwqP8058jtZTID2m3Ffw4sk+KcwPTjLQOH zoS2OSGDT/j85Z+IBPkYxGV5LL3SgFS2/uOLYnlQzcqX5T1aDPRu25bRiu2RhuPOqUTAmZU3mPiqi ngO8OsFWV0gVTmvaTcxBnaIgE+ryNaFkB0hdvTJvN36B69dpXmaRm25sMfrcQiu3iYDuyNkoRKkew 9d9AQGsvK0Wda/QXah9I5Q==; Original-Received: from [87.69.77.57] (port=3312 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKJKK-0006iN-Bj; Wed, 16 Feb 2022 07:22:32 -0500 In-Reply-To: <87h78zv1hc.fsf@yahoo.com> (message from Po Lu on Wed, 16 Feb 2022 13:12:31 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286377 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Wed, 16 Feb 2022 13:12:31 +0800 > > Po Lu writes: > > > I installed a change on master that should avert this problem. I > > couldn't find a way to decode the XIM callback data inside keyboard.c, > > but handling the errors with internal_condition_case seems to work. > > BTW, the same problem exists on the release branch when built with > recent versions of GLib. > > Would it be worth fixing the bug there as well? Thanks. Only if this is a recent problem. Otherwise, I'd prefer not to introduce such non-trivial code into the release branch so late into the pretest.