From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54802: OClosure: Make `interactive-form` a generic function Date: Tue, 19 Apr 2022 16:00:58 +0300 Message-ID: <83fsm9ut11.fsf@gnu.org> References: <87r161to4p.fsf@yahoo.com> <87v8vbrx4w.fsf@yahoo.com> <878rs7rus8.fsf@yahoo.com> <87fsmfq8dl.fsf@yahoo.com> <83wnfq1fzg.fsf@gnu.org> <83v8v5vdey.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10643"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 54802@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 19 15:02:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ngnUv-0002fb-DT for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Apr 2022 15:02:25 +0200 Original-Received: from localhost ([::1]:49018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngnUt-0005jZ-Nj for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Apr 2022 09:02:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33354) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngnUZ-0005he-66 for bug-gnu-emacs@gnu.org; Tue, 19 Apr 2022 09:02:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48104) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ngnUY-0003Og-OV for bug-gnu-emacs@gnu.org; Tue, 19 Apr 2022 09:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ngnUY-000478-KX for bug-gnu-emacs@gnu.org; Tue, 19 Apr 2022 09:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Apr 2022 13:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54802 X-GNU-PR-Package: emacs Original-Received: via spool by 54802-submit@debbugs.gnu.org id=B54802.165037327513374 (code B ref 54802); Tue, 19 Apr 2022 13:02:02 +0000 Original-Received: (at 54802) by debbugs.gnu.org; 19 Apr 2022 13:01:15 +0000 Original-Received: from localhost ([127.0.0.1]:41999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngnTm-0003TN-Ve for submit@debbugs.gnu.org; Tue, 19 Apr 2022 09:01:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngnTl-0003Nz-W3 for 54802@debbugs.gnu.org; Tue, 19 Apr 2022 09:01:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37392) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngnTg-0003H1-8u; Tue, 19 Apr 2022 09:01:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FDuWmw2R5vQQOL625mCV2BYnrMM6RhOK9v9YpMd50KI=; b=o37R2QPP9aad rk11xsunDBKh4q+lRQ6TcNRgqL65b6G4FR6ACa/uQOttiflZCbImLFSGUCi7k3nlX9omYIqDiBbmN 61q1nzH/T8M3YcyZ7//ZTjZ5eQmGr3PErQe47WywfDid++ZZdMg0hyxC1xzIm/Zwp5QrtyWgbPt1t OdjspdsDr+TQb8duqwi2dTg9JBLLVNkKkhlsNsscB84Q2CeERUs8p88QQ6jxHo1VTfSq6HUu8NNku Nc59tah8houazDdn4Ub1TdPnhLXt5JtzoJaEKaNYiHcImXvcQz+xqJVVQlvHG97+mDL+A9RP1/Dgq gJqVCO81BG5YoYYLSkALFg==; Original-Received: from [87.69.77.57] (port=3681 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngnTf-0000UE-15; Tue, 19 Apr 2022 09:01:08 -0400 In-Reply-To: (message from Stefan Monnier on Tue, 19 Apr 2022 08:38:47 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230238 Archived-At: > From: Stefan Monnier > Cc: luangruo@yahoo.com, 54802@debbugs.gnu.org > Date: Tue, 19 Apr 2022 08:38:47 -0400 > > > I'm sorry, but I think the cleanest fix is too much to pay for a minor > > feature such as this one. > > I don't see much price to pay here. See below. > Am I the only here who finds that defining `interactive-form` as > an ELisp generic function is, in itself, a good idea (not good enough > to do it without a good reason, but something I put on the side of > "advantages" rather than "defects" when assessing my patch)? Maybe you aren't the only one, but I don't share that opinion. And in this particular case, I don't even consider the reason to be anywhere near "good enough". > > Can't you find a less intrusive way of fixing these issues, one that > > doesn't affect all of Emacs for the benefit of one or two packages of > > minor importance? > > Not sure what you mean by "affect all of Emacs". It affects > a well-delimited (and small) part of the code. It is called outside of the advice functions. > Are you worried about introducing bugs, about the performance impact, > or something else? All of them. And again, the reason doesn't seem to justify the risks, not IMO.