From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55163: 29.0.50; master 4a1f69ebca (TICKS . HZ) for current-time broke lsp-mode Date: Thu, 28 Apr 2022 16:38:47 +0300 Message-ID: <83fslxba54.fsf@gnu.org> References: <87sfpxxyvb.fsf@3-191.divsi.unimi.it> <87zgk5jtm6.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31223"; mail-complaints-to="usenet@ciao.gmane.io" Cc: v.pupillo@gmail.com, 55163@debbugs.gnu.org, eggert@cs.ucla.edu To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 28 15:39:41 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nk4Mu-0007uB-Nw for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 15:39:40 +0200 Original-Received: from localhost ([::1]:40344 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nk4Mt-0004ww-CR for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 09:39:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48270) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk4MI-0004wG-P8 for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 09:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51918) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nk4MI-0002EZ-GB for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 09:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nk4MI-00054z-BZ for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 09:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2022 13:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55163 X-GNU-PR-Package: emacs Original-Received: via spool by 55163-submit@debbugs.gnu.org id=B55163.165115313719515 (code B ref 55163); Thu, 28 Apr 2022 13:39:02 +0000 Original-Received: (at 55163) by debbugs.gnu.org; 28 Apr 2022 13:38:57 +0000 Original-Received: from localhost ([127.0.0.1]:45815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk4MD-00054g-5m for submit@debbugs.gnu.org; Thu, 28 Apr 2022 09:38:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk4MB-00054T-0L for 55163@debbugs.gnu.org; Thu, 28 Apr 2022 09:38:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51582) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk4M4-0002Cv-Vd; Thu, 28 Apr 2022 09:38:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=H+ssUpTNFCddooNI9EUscCsW2nLJzQabfjGC9Kio4QQ=; b=nZpD9mI8WOs4 bOBfHlypB3m53rbAQrrSM0T6mR1zBX8vQOJml7wKVdcO4EByjogPNFhRCND5ltJZXs8+cWBEXl0Wm OLvGjxH+RWmKAQtdOsXgeN1nS0WVOvCRte6oJRs23OovByYD8bOpN7mqkBHGWMwsrEt2kYZC1NxhT 4Ft/apF5IxpyStgnf7aeHlAixrXFjKmDVDRcTIxN35kK+dV2cmvUMcLWunbExYr9mWSKBjM954sDf gJc54+QJJH1HHnL3jfafYDVuMJKXItP0M273lcJISuuF2vGjlOBBOwqESirgwOOUROxi1pPrK6wo9 fGv2aRThOPn3jf8FD/GNpA==; Original-Received: from [87.69.77.57] (port=2686 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk4M4-00016P-Ef; Thu, 28 Apr 2022 09:38:48 -0400 In-Reply-To: <87zgk5jtm6.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 28 Apr 2022 14:10:57 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230878 Archived-At: > From: Lars Ingebrigtsen > Cc: 55163@debbugs.gnu.org, Paul Eggert , Eli Zaretskii > > Date: Thu, 28 Apr 2022 14:10:57 +0200 > > Vincenzo Pupillo writes: > > > the recent patch 4a1f69ebca broke the lsp-mode logging code. The logging code uses the expression > > expression (/ (nth 2 (time-since before-send)) 1000) to > > calculate the time of the event to be logged. lsp-mode starts the lsp-server, but is unable to work. > > Paul, it seems like this change is just breaking too much code out > there, so I think it'll have to be reverted. > > Eli, what do you think? I tend to agree. I actually didn't expect Paul to make such changes, given the recent discussion on emacs-devel, where he seemed to agree with my argument against this kind of changes. But he did make this change regardless.